* [gentoo-dev] Non-maintainer commits and CI
@ 2021-01-07 14:28 Agostino Sarubbo
2021-01-07 14:40 ` Sam James
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Agostino Sarubbo @ 2021-01-07 14:28 UTC (permalink / raw
To: gentoo-dev
Hello,
it happens frequently that CI discovers failure(s) in non-maintainer commits.
The most striking examples are maintainer-needed, proxy-maint and general pull
request where who made the change has no visibility on the new bug.
Do you think that is a good idea to CC everyone involved in the commit?
Agostino
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Non-maintainer commits and CI
2021-01-07 14:28 [gentoo-dev] Non-maintainer commits and CI Agostino Sarubbo
@ 2021-01-07 14:40 ` Sam James
2021-01-07 15:31 ` Joonas Niilola
2021-03-01 14:24 ` Sam James
2 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2021-01-07 14:40 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
> On 7 Jan 2021, at 14:28, Agostino Sarubbo <ago@gentoo.org> wrote:
>
> Hello,
>
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
>
> The most striking examples are maintainer-needed, proxy-maint and general pull
> request where who made the change has no visibility on the new bug.
>
> Do you think that is a good idea to CC everyone involved in the commit?
>
Yes please, that’d be extremely helpful and I don’t see any reason not to from my POV.
I keep an eye on recently changed/new bugs out of habit, but this is a great
way to help avoid things being lost.
>
> Agostino
>
>
>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Non-maintainer commits and CI
2021-01-07 14:28 [gentoo-dev] Non-maintainer commits and CI Agostino Sarubbo
2021-01-07 14:40 ` Sam James
@ 2021-01-07 15:31 ` Joonas Niilola
2021-03-01 14:24 ` Sam James
2 siblings, 0 replies; 4+ messages in thread
From: Joonas Niilola @ 2021-01-07 15:31 UTC (permalink / raw
To: gentoo-dev
On 1/7/21 4:28 PM, Agostino Sarubbo wrote:
> Hello,
>
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
>
> The most striking examples are maintainer-needed, proxy-maint and general pull
> request where who made the change has no visibility on the new bug.
>
> Do you think that is a good idea to CC everyone involved in the commit?
>
>
> Agostino
>
>
>
Overall yes, I think this is a good idea. One should be held responsible
to one's commits even for m-n packages.
But then again I wouldn't wish to be reminded about
CFLAGS/LDFLAGS/cc/ar/etc after fixing some bug unrelated to these. If
there's a CFLAGS/LDFLAGS/etc bug open for 1.2.3 do you usually report a
new one for 1.2.3-r1 or 1.2.4?
-- juippis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Non-maintainer commits and CI
2021-01-07 14:28 [gentoo-dev] Non-maintainer commits and CI Agostino Sarubbo
2021-01-07 14:40 ` Sam James
2021-01-07 15:31 ` Joonas Niilola
@ 2021-03-01 14:24 ` Sam James
2 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2021-03-01 14:24 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
> On 7 Jan 2021, at 14:28, Agostino Sarubbo <ago@gentoo.org> wrote:
>
> Hello,
>
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
>
> The most striking examples are maintainer-needed, proxy-maint and general pull
> request where who made the change has no visibility on the new bug.
>
> Do you think that is a good idea to CC everyone involved in the commit?
>
Hi all,
Following up on this, ago has implemented this after I brought it up to him - thank you ago!
The committer will be CCed on bugs and upon requests this can be disabled where maintainer is a member
of a project alias (to avoid receive mail from both herd and CC).
If needed, we could revisit this and turn it into a whitelist or something, but for now,
the aim is to just blacklist “alive” projects where people read the alias.
Best,
Sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-01 14:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-07 14:28 [gentoo-dev] Non-maintainer commits and CI Agostino Sarubbo
2021-01-07 14:40 ` Sam James
2021-01-07 15:31 ` Joonas Niilola
2021-03-01 14:24 ` Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox