From: Thomas Deutschmann <whissi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
Date: Fri, 11 Oct 2019 17:59:06 +0200 [thread overview]
Message-ID: <0403687e-6496-84d0-e649-8e29974044fc@gentoo.org> (raw)
In-Reply-To: <w6geezlgequ.fsf@kph.uni-mainz.de>
[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]
On 2019-10-10 10:56, Ulrich Mueller wrote:
>>>>>> On Thu, 10 Oct 2019, Mike Pagano wrote:
>
>> + GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
>
> The ~ should be backslash-escaped or quoted, otherwise it will be
> expanded if there's a user mpagano or whissi on the system. :-)
Just curious, are you sure? I think this is wrong:
Tilde expansion only happens when string to expand starts with "~" but
this is not the case here (string starts with "https...").
I also tried that code and it's working fine for me...
--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2019-10-11 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 17:01 [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace Mike Pagano
2019-10-09 18:26 ` Ulrich Mueller
2019-10-09 19:31 ` [gentoo-dev] [PATCH v2 " Mike Pagano
2019-10-09 20:19 ` Michał Górny
2019-10-09 23:14 ` [gentoo-dev] [PATCH v3 " Mike Pagano
2019-10-10 8:56 ` Ulrich Mueller
2019-10-10 11:25 ` [gentoo-dev] [PATCH v4 " Mike Pagano
2019-10-11 15:59 ` Thomas Deutschmann [this message]
2019-10-12 10:35 ` [gentoo-dev] [PATCH v3 " Ulrich Mueller
2019-10-12 19:04 ` Mike
2019-10-10 1:23 ` [gentoo-dev] [PATCH " Alec Warner
2019-10-10 10:04 ` Mike Pagano
2019-10-10 16:15 ` Mikle Kolyada
2019-10-11 18:28 ` Alec Warner
2019-10-11 20:52 ` Mike Pagano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0403687e-6496-84d0-e649-8e29974044fc@gentoo.org \
--to=whissi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox