From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5B520158086 for ; Mon, 11 Oct 2021 11:13:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A9FCAE0871; Mon, 11 Oct 2021 11:13:50 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 51C1BE086A for ; Mon, 11 Oct 2021 11:13:50 +0000 (UTC) Message-ID: <036da017ca4f68823c309e908276c1394eeb0f06.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Cc: ml@gentoo.org, Sam James Date: Mon, 11 Oct 2021 13:13:43 +0200 In-Reply-To: <20211011050759.2896218-1-sam@gentoo.org> References: <20211011050759.2896218-1-sam@gentoo.org> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: e68d98a6-5c54-4b51-a5eb-e8b52ce2b5c7 X-Archives-Hash: b77eb37dc19f4d0a31d0a521dea2e47b On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote: > This breaks at least ocamlopt. > > Closes: https://bugs.gentoo.org/803047 > Closes: https://bugs.gentoo.org/811315 > Signed-off-by: Sam James > --- >  eclass/dune.eclass | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/eclass/dune.eclass b/eclass/dune.eclass > index 02a8a870ef43e..8a6e01893932a 100644 > --- a/eclass/dune.eclass > +++ b/eclass/dune.eclass > @@ -28,6 +28,9 @@ esac >  # Do not complain about CFLAGS etc since ml projects do not use > them. >  QA_FLAGS_IGNORED='.*' >   > +# Breaks with ocamlopt > +RESTRICT="strip" > + err this is a terrible idea to do at such a large scale, esp. since nowadays you can use dostrip -x and provide proper comments as to what and why something breaks when stripped on a case by case basis