[gentoo-dev] Non-maintainer commits and CI

[gentoo-dev] Non-maintainer commits and CI

[Agostino Sarubbo]

Hello,

it happens frequently that CI discovers failure(s) in non-maintainer commits.

The most striking examples are maintainer-needed, proxy-maint and general pull 
request where who made the change has no visibility on the new bug.

Do you think that is a good idea to CC everyone involved in the commit?


Agostino

Re: [gentoo-dev] Non-maintainer commits and CI

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]


> On 7 Jan 2021, at 14:28, Agostino Sarubbo <ago@gentoo.org> wrote:
> 
> Hello,
> 
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
> 
> The most striking examples are maintainer-needed, proxy-maint and general pull
> request where who made the change has no visibility on the new bug.
> 
> Do you think that is a good idea to CC everyone involved in the commit?
> 

Yes please, that’d be extremely helpful and I don’t see any reason not to from my POV.

I keep an eye on recently changed/new bugs out of habit, but this is a great
way to help avoid things being lost.


> 
> Agostino
> 
> 
> 


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

Re: [gentoo-dev] Non-maintainer commits and CI

[Joonas Niilola]

On 1/7/21 4:28 PM, Agostino Sarubbo wrote:
> Hello,
>
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
>
> The most striking examples are maintainer-needed, proxy-maint and general pull 
> request where who made the change has no visibility on the new bug.
>
> Do you think that is a good idea to CC everyone involved in the commit?
>
>
> Agostino
>
>
>
Overall yes, I think this is a good idea. One should be held responsible
to one's commits even for m-n packages.

But then again I wouldn't wish to be reminded about
CFLAGS/LDFLAGS/cc/ar/etc after fixing some bug unrelated to these. If
there's a CFLAGS/LDFLAGS/etc bug open for 1.2.3 do you usually report a
new one for 1.2.3-r1 or 1.2.4?

-- juippis

Re: [gentoo-dev] Non-maintainer commits and CI

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


> On 7 Jan 2021, at 14:28, Agostino Sarubbo <ago@gentoo.org> wrote:
> 
> Hello,
> 
> it happens frequently that CI discovers failure(s) in non-maintainer commits.
> 
> The most striking examples are maintainer-needed, proxy-maint and general pull
> request where who made the change has no visibility on the new bug.
> 
> Do you think that is a good idea to CC everyone involved in the commit?
> 

Hi all,

Following up on this, ago has implemented this after I brought it up to him - thank you ago!

The committer will be CCed on bugs and upon requests this can be disabled where maintainer is a member
of a project alias (to avoid receive mail from both herd and CC).

If needed, we could revisit this and turn it into a whitelist or something, but for now,
the aim is to just blacklist “alive” projects where people read the alias.

Best,
Sam

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]