* [gentoo-dev] Script to make list of ebuilds without $Header$
@ 2001-08-15 7:50 Dan Armak
2001-08-15 8:08 ` Dan Armak
2001-08-15 9:15 ` Chad M. Huneycutt
0 siblings, 2 replies; 9+ messages in thread
From: Dan Armak @ 2001-08-15 7:50 UTC (permalink / raw
To: gentoo-dev
Hi all,
The following construct:
#! /bin/sh
for X in `find /usr/portage/ -name *.ebuild | sort`;
do
grep "\$Header" ${X} > /dev/null || echo ${X}
done
Gives a list of ebuilds without "$Header" in them, which is so long I don't
want to post it here, run it yuorself and see. It has ~230 items listed,
versus ~1020 items for a search of ebuilds that do have $Header lines
(replace || with && in script).
I think these should be fixed as a group, but don't have a
good MDI text editor right now. If noone fixes these before I get one (Kate
from kde-2.2 which I'll install tonight), I will fix them tomorrow.
--
Dan Armak
Gentoo Linux Developer, Desktop Team
Matan, Israel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 7:50 [gentoo-dev] Script to make list of ebuilds without $Header$ Dan Armak
@ 2001-08-15 8:08 ` Dan Armak
2001-08-15 11:15 ` Dan Armak
2001-08-15 9:15 ` Chad M. Huneycutt
1 sibling, 1 reply; 9+ messages in thread
From: Dan Armak @ 2001-08-15 8:08 UTC (permalink / raw
To: gentoo-dev
> I think these should be fixed as a group, but don't have a
> good MDI text editor right now. If noone fixes these before I get one (Kate
> from kde-2.2 which I'll install tonight), I will fix them tomorrow.
Of course, hand fixing 230 ebuilds is a big pain. On the other hand if we
auto-insert $Header$ as the 4th line of an ebuild for example, most of them
will have broken remains, usually some form of Header without the $s. Do you
think that's ok?
--
Dan Armak
Gentoo Linux Developer, Desktop Team
Matan, Israel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 7:50 [gentoo-dev] Script to make list of ebuilds without $Header$ Dan Armak
2001-08-15 8:08 ` Dan Armak
@ 2001-08-15 9:15 ` Chad M. Huneycutt
2001-08-15 11:30 ` Dan Armak
1 sibling, 1 reply; 9+ messages in thread
From: Chad M. Huneycutt @ 2001-08-15 9:15 UTC (permalink / raw
To: gentoo-dev
Dan Armak wrote:
>Hi all,
>
>The following construct:
>
>#! /bin/sh
>for X in `find /usr/portage/ -name *.ebuild | sort`;
>do
>
> grep "\$Header" ${X} > /dev/null || echo ${X}
>
>done
>
Why don't we add two lines as the 4th and fifth line:
# $Header$
# ****** DELETE ANY BROKEN HEADER LINES, PLEASE *****
That way developers can clean up the headers as they modify an ebuild.
Chad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
@ 2001-08-15 10:42 Peter Kadau
0 siblings, 0 replies; 9+ messages in thread
From: Peter Kadau @ 2001-08-15 10:42 UTC (permalink / raw
To: gentoo-dev
hi !
> #! /bin/sh
> for X in `find /usr/portage/ -name *.ebuild | sort`;
> do
>
> grep "\$Header" ${X} > /dev/null || echo ${X}
>
> done
i'd rather do an
find /usr/portage -name '*.ebuild' | xargs grep -E -L \ '^[[:blank:]]*#[[:blank:]]*\$HEADER\$[[:blank:]]*$'
because it doesn't fork for every file.
> Dan Armak
ciao
peter
-----------------------------------------------------------------
peter kadau
email: peter.kadau@web.de
open source is no religion - it just produces the most reliable software
-----------------------------------------------------------------
______________________________________________________________________________
Ferienklick.de - Urlaub ist schön!
Hier geht's zum Traumstrand: http://ferienklick.de/?PP=2-5-100-105-13
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 8:08 ` Dan Armak
@ 2001-08-15 11:15 ` Dan Armak
0 siblings, 0 replies; 9+ messages in thread
From: Dan Armak @ 2001-08-15 11:15 UTC (permalink / raw
To: gentoo-dev
> Of course, hand fixing 230 ebuilds is a big pain. On the other hand if we
> auto-insert $Header$ as the 4th line of an ebuild for example, most of them
> will have broken remains, usually some form of Header without the $s. Do
> you think that's ok?
So sorry for writing in pieces. This is a final summary:
Either I fix all ebuilds with e.g. a sed transform to put in a 4th or 5th
line etc. with $Header$, leaving possible ebuild-specific problems and
litter, or every developer looks at the list and fixes his own ebuilds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 9:15 ` Chad M. Huneycutt
@ 2001-08-15 11:30 ` Dan Armak
2001-08-15 12:44 ` Daniel Robbins
0 siblings, 1 reply; 9+ messages in thread
From: Dan Armak @ 2001-08-15 11:30 UTC (permalink / raw
To: gentoo-dev
> Why don't we add two lines as the 4th and fifth line:
> # $Header$
> # ****** DELETE ANY BROKEN HEADER LINES, PLEASE *****
That's easy enough to do. As long as we're sure that the 4th/5th line is
always the correct position. Can someone think of a problematic case? Do I
get the "go-ahead"?
--
Dan Armak
Gentoo Linux Developer, Desktop Team
Matan, Israel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 11:30 ` Dan Armak
@ 2001-08-15 12:44 ` Daniel Robbins
2001-08-15 12:56 ` Dan Armak
2001-08-30 6:12 ` Parag Mehta
0 siblings, 2 replies; 9+ messages in thread
From: Daniel Robbins @ 2001-08-15 12:44 UTC (permalink / raw
To: gentoo-dev
On Wed, Aug 15, 2001 at 08:25:48PM +0300, Dan Armak wrote:
> > Why don't we add two lines as the 4th and fifth line:
> > # $Header$
> > # ****** DELETE ANY BROKEN HEADER LINES, PLEASE *****
> That's easy enough to do. As long as we're sure that the 4th/5th line is
> always the correct position. Can someone think of a problematic case? Do I
> get the "go-ahead"?
Please just start fixing them manually. I don't want you clobbering the
Portage tree with sed. Use scripts in a limited fashion for those ebuilds
*with* valid comment areas.
--
Daniel Robbins <drobbins@gentoo.org>
Chief Architect/President http://www.gentoo.org
Gentoo Technologies, Inc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 12:44 ` Daniel Robbins
@ 2001-08-15 12:56 ` Dan Armak
2001-08-30 6:12 ` Parag Mehta
1 sibling, 0 replies; 9+ messages in thread
From: Dan Armak @ 2001-08-15 12:56 UTC (permalink / raw
To: gentoo-dev
On Wednesday 15 August 2001 21:43, you wrote:
> On Wed, Aug 15, 2001 at 08:25:48PM +0300, Dan Armak wrote:
> > > Why don't we add two lines as the 4th and fifth line:
> > > # $Header$
> > > # ****** DELETE ANY BROKEN HEADER LINES, PLEASE *****
> >
> > That's easy enough to do. As long as we're sure that the 4th/5th line is
> > always the correct position. Can someone think of a problematic case? Do
> > I get the "go-ahead"?
>
> Please just start fixing them manually. I don't want you clobbering the
> Portage tree with sed. Use scripts in a limited fashion for those ebuilds
> *with* valid comment areas.
Hm, I can't do anything today, but tomorrow I just might write a script that
calls cvs log on files found and lists Header-less ebuilds by author (last
commiter). Than it'd be organized.
--
Dan Armak
Gentoo Linux Developer, Desktop Team
Matan, Israel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [gentoo-dev] Script to make list of ebuilds without $Header$
2001-08-15 12:44 ` Daniel Robbins
2001-08-15 12:56 ` Dan Armak
@ 2001-08-30 6:12 ` Parag Mehta
1 sibling, 0 replies; 9+ messages in thread
From: Parag Mehta @ 2001-08-30 6:12 UTC (permalink / raw
To: gentoo-dev
Hi Daniel!
my $0.02 inline or at the end
* Daniel Robbins assembled some ascibets to say:
Daniel >
Daniel >Please just start fixing them manually. I don't want you clobbering the
Daniel >Portage tree with sed. Use scripts in a limited fashion for those ebuilds
Daniel >*with* valid comment areas.
hv fixed them manually in each and every file and will be committing them after i get a confirmation from daniel stating i can commit them.
Best Regards,
pm
--
Developer <pm@gentoo.org>
Gentoo Linux http://gentoo.org
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2001-08-30 12:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-15 7:50 [gentoo-dev] Script to make list of ebuilds without $Header$ Dan Armak
2001-08-15 8:08 ` Dan Armak
2001-08-15 11:15 ` Dan Armak
2001-08-15 9:15 ` Chad M. Huneycutt
2001-08-15 11:30 ` Dan Armak
2001-08-15 12:44 ` Daniel Robbins
2001-08-15 12:56 ` Dan Armak
2001-08-30 6:12 ` Parag Mehta
-- strict thread matches above, loose matches on Subject: below --
2001-08-15 10:42 Peter Kadau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox