[gentoo-dev] typo in sawfish-2.0 source

[gentoo-dev] typo in sawfish-2.0 source

[Tobias J. Schwinger]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

sawfish-2.0 didn't want to compile on my configuration.

i found a typo in gtk_style.c line 100:

98:  /* If GTK_MINOR_VERSION is not set 2 we are using gtk+ 1.3.x or 2.0
99:     so these two members are no more */
100: #if (GTK_MINOR_VERSION == 0)

i believe the author meant:

100: #if (GTK_MINOR_VERSION != 0)


i changed it and it compiled just fine

[-- Attachment #2: Type: text/html, Size: 1365 bytes --]

Re: [gentoo-dev] typo in sawfish-2.0 source

[foser]

On Mon, 2003-06-02 at 20:31, Tobias J. Schwinger wrote:
> sawfish-2.0 didn't want to compile on my configuration.

If you wanted the latest sawfish for gtk+-2.0 you should install 1.3,
that's really the latest version and it has a better gtk version check.
Sawfish for gtk+ 2 had some weird versioning  jumps.

The check was ok around the time sawfish-2.0 was released around the
time gtk+-2.0 hit the streets, but isn't correct anymore with gtk+-2.2
in the tree. Your check isn't completely correct either, cause sawfish
will work with gtk+-2.0 just fine (it checks the minor version no.).

I removed the 2.0 ebuild.

- foser


--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] typo in sawfish-2.0 source

[Tobias J. Schwinger]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

----- Original Message ----- 
From: "foser" <foser@foser.dyn.warande.net>
To: <gentoo-dev@gentoo.org>
Sent: 02 June, 2003 23:44
Subject: Re: [gentoo-dev] typo in sawfish-2.0 source


> The check was ok around the time sawfish-2.0 was released around the
> time gtk+-2.0 hit the streets, but isn't correct anymore with gtk+-2.2
> in the tree. Your check isn't completely correct either, cause sawfish
> will work with gtk+-2.0 just fine (it checks the minor version no.).


OH !  I REALIZE THAT WAS STUPID - I'M SORRY I DIDN'T WANT TO CONFUSE ANYONE.

thanx for pointing it out.

[-- Attachment #2: Type: text/html, Size: 1687 bytes --]