From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NiaLF-0000HU-Q9 for garchives@archives.gentoo.org; Fri, 19 Feb 2010 21:24:54 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 52C9CE0950; Fri, 19 Feb 2010 21:24:07 +0000 (UTC) Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by pigeon.gentoo.org (Postfix) with ESMTP id 0D708E0950 for ; Fri, 19 Feb 2010 21:24:06 +0000 (UTC) Received: by bwz19 with SMTP id 19so449326bwz.26 for ; Fri, 19 Feb 2010 13:23:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=Dmf34NsIXcen9cU5gev969PjYsBstu9up1YLw0sCQEE=; b=sQhwVXH+c/VFXwH1GG1WM2v4LCbYAdhO/JQeGv/0EbTDoVPComo1V85nJ8aSxP3Vb9 UW60bi4ngifDNL9eef+SNyynWKJkktZJ4eP5rDxGd9lAraHJUvNspl2odkx6d1lf36K1 eEqREkItHsMTOLc/jIy4/hY2tvgzWKn3a1OqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=kjwsh1qir88D1Gvdx1QMtJiJiuy8/igk2CTIfOr5E57iLf2ERgsg5CWbxm822PCvCu Gog2Lcd0ZnPQDuEJzCmyJ3M0ryhcBJONJPXGWLwlrxn9jhfsl8zlGY15c277ecpz7ZFf 2MDHaeHhbBQiIToHsU8UWiSEw/kDtOq1lWvzg= Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-desktop@lists.gentoo.org Reply-to: gentoo-desktop@lists.gentoo.org MIME-Version: 1.0 Received: by 10.204.174.201 with SMTP id u9mr7398547bkz.204.1266614638687; Fri, 19 Feb 2010 13:23:58 -0800 (PST) Date: Fri, 19 Feb 2010 22:23:58 +0100 Message-ID: <255f067f1002191323t22479b8cl9a05a130229fb35d@mail.gmail.com> Subject: [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass From: Ladislav Laska To: gentoo-desktop@lists.gentoo.org, Martin von Gagern Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: f8afa0d4-a443-44b2-8f3a-8c59f027eeaf X-Archives-Hash: 2eb0f5ee0689de8740313ca845bc2d8c Hello again, I have decided to continue discussion in new thread. This discussion was started in thread "kde-sunset: kdepim-kresources broken". I have replaced my code with what I originally intended (the code in git is wrong, since I made a mistake editing it - here is what I intended): # Check for PATCHES in EAPI=0|1 case ${EAPI:-0} in 0|1) if [[ -n ${PATCHES} ]] && [[ -d "${KDE_S}" ]]; then base_src_prepare fi ;; esac Look, for example, at kde-base/ark ebuild. There is a patch, but it's not applied correctly without my code. What I'm worried about is the check [[ -d "${KDE_S}" ]] makes sure, that this code is called if [[ -d "${KDE_S}" ]] || base_src_unpack unpack did not called base-src_unpack and therefore did not applied patches. There are two problems with EAPI=0|1 1) It depends on file naming and will not work if base_src_unpack unpacks into $KDE_S 2) Even if base_src_unpack calls base_src_prepare, we're adding patches automatically after this call, but they will not be applied. Since I can't think of correct check, please let me know if you have an idea. Also, let me know if I'm wrong about something and it's not needed at all. (but I doubt that, because ark, as mentioned above, is counterexample) Regards Ladislav Laska S pozdravem Ladislav Laska --- xmpp/jabber: ladislav.laska@jabber.cz