From: Ladislav Laska <ladislav.laska@gmail.com>
To: gentoo-desktop@lists.gentoo.org,
Martin von Gagern <Martin.vGagern@gmx.net>
Subject: [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass
Date: Fri, 19 Feb 2010 22:23:58 +0100 [thread overview]
Message-ID: <255f067f1002191323t22479b8cl9a05a130229fb35d@mail.gmail.com> (raw)
Hello again,
I have decided to continue discussion in new thread. This discussion
was started in thread "kde-sunset: kdepim-kresources broken".
I have replaced my code with what I originally intended (the code in
git is wrong, since I made a mistake editing it - here is what I
intended):
# Check for PATCHES in EAPI=0|1
case ${EAPI:-0} in
0|1)
if [[ -n ${PATCHES} ]] && [[ -d "${KDE_S}" ]]; then
base_src_prepare
fi
;;
esac
Look, for example, at kde-base/ark ebuild. There is a patch, but it's
not applied correctly without my code.
What I'm worried about is the check [[ -d "${KDE_S}" ]] makes sure,
that this code is called if
[[ -d "${KDE_S}" ]] || base_src_unpack unpack
did not called base-src_unpack and therefore did not applied patches.
There are two problems with EAPI=0|1
1) It depends on file naming and will not work if base_src_unpack
unpacks into $KDE_S
2) Even if base_src_unpack calls base_src_prepare, we're adding
patches automatically after this call, but they will not be applied.
Since I can't think of correct check, please let me know if you have
an idea. Also, let me know if I'm wrong about something and it's not
needed at all. (but I doubt that, because ark, as mentioned above, is
counterexample)
Regards Ladislav Laska
S pozdravem Ladislav Laska
---
xmpp/jabber: ladislav.laska@jabber.cz
next reply other threads:[~2010-02-19 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 21:23 Ladislav Laska [this message]
2010-02-20 10:02 ` [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass Martin von Gagern
2010-02-20 23:08 ` Ladislav Laska
2010-02-21 14:53 ` Chris Bandy
2010-02-21 17:09 ` Ladislav Laska
2010-02-21 18:55 ` Martin von Gagern
2010-02-22 3:23 ` Chris Bandy
2010-02-22 11:58 ` Andrew John Hughes
2010-02-23 17:27 ` [gentoo-desktop] " Duncan
2010-02-23 21:33 ` Andrew John Hughes
2010-02-25 1:14 ` Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=255f067f1002191323t22479b8cl9a05a130229fb35d@mail.gmail.com \
--to=ladislav.laska@gmail.com \
--cc=Martin.vGagern@gmx.net \
--cc=gentoo-desktop@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox