From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1R8ZD1-0003uS-GU for garchives@archives.gentoo.org; Tue, 27 Sep 2011 15:04:36 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6208421C0CE; Tue, 27 Sep 2011 15:04:24 +0000 (UTC) Received: from powerman.name (powerman.name [85.90.198.1]) by pigeon.gentoo.org (Postfix) with ESMTP id 3945421C026 for ; Tue, 27 Sep 2011 15:04:03 +0000 (UTC) Received: (qmail 17410 invoked by uid 1000); 27 Sep 2011 15:04:03 -0000 Date: Tue, 27 Sep 2011 18:04:03 +0300 From: Alex Efros To: gentoo-desktop@lists.gentoo.org Subject: [gentoo-desktop] [PATCH] amarok-1.4.10_p20090130-r4 fail to compile Message-ID: <20110927150403.GI4290@home.power> Mail-Followup-To: gentoo-desktop@lists.gentoo.org Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-desktop@lists.gentoo.org Reply-to: gentoo-desktop@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="CblX+4bnyfN0pR09" Content-Disposition: inline Organization: http://powerman.name/ User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: X-Archives-Hash: d99bf5759ec82a57a0a471721e36fc83 --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! Error from build log: ---cut--- In file included from amarokdcophandler.cpp:36:0: ../../../amarok/src/osd.h: At global scope: ../../../amarok/src/osd.h:40:74: error: cannot call constructor 'QImage::QImage' directly ../../../amarok/src/osd.h:40:74: error: for a function-style cast, remove the redundant '::QImage' ---cut--- Patch (duplicated in attach): ---cut--- --- amarok/src/osd.h.orig 2011-09-27 17:47:26.000000000 +0300 +++ amarok/src/osd.h 2011-09-27 17:47:43.000000000 +0300 @@ -37,7 +37,7 @@ public slots: /** calls setText() then show(), after setting image if needed */ - void show( const QString &text, QImage newImage = QImage::QImage() ); + void show( const QString &text, QImage newImage = QImage() ); void ratingChanged( const short rating ); void ratingChanged( const QString& path, int rating ); void volChanged( unsigned char volume ); ---cut--- I noticed this issue when re-emerging @world after upgrading gcc 4.4.5 to 4.5.3, but probably this issue have nothing with gcc and related to some previous qt upgrade, so I named patch file amarok-qt3-4.7.patch but I'm not sure this is correct name. -- WBR, Alex. --CblX+4bnyfN0pR09 Content-Type: application/x-patch Content-Disposition: attachment; filename="amarok-qt3-4.7.patch" Content-Transfer-Encoding: quoted-printable --- amarok/src/osd.h.orig 2011-09-27 17:47:26.000000000 +0300=0A+++ amarok/= src/osd.h 2011-09-27 17:47:43.000000000 +0300=0A@@ -37,7 +37,7 @@=0A =0A = public slots:=0A /** calls setText() then show(), after setting= image if needed */=0A- void show( const QString &text, QImage newIm= age =3D QImage::QImage() );=0A+ void show( const QString &text, QIma= ge newImage =3D QImage() );=0A void ratingChanged( const short rati= ng );=0A void ratingChanged( const QString& path, int rating );=0A = void volChanged( unsigned char volume );=0A --CblX+4bnyfN0pR09 Content-Type: application/x-patch Content-Disposition: attachment; filename="amarok-1.4.10_p20090130-r4.ebuild.patch" Content-Transfer-Encoding: quoted-printable --- /var/lib/layman/kde-sunset/media-sound/amarok/amarok-1.4.10_p20090130-r= 4.ebuild 2010-11-14 21:17:44.000000000 +0200=0A+++ amarok-1.4.10_p20090130-= r4.ebuild 2011-09-27 17:49:36.000000000 +0300=0A@@ -77,6 +77,7 @@=0A "${FI= LESDIR}/${PN}-libmp4v2.patch"=0A "${FILESDIR}/${PN}-libmp4v2-2.patch"=0A = "${FILESDIR}/${PN}-1.4.10-fix-autoconf-2.64.patch"=0A+ "${FILESDIR}/${PN}-q= t3-4.7.patch"=0A "${WORKDIR}/${PN}-1.4.10-post20090130.diff"=0A "${WORKDI= R}/${PN}-1.4.10-desktop-entry.diff"=0A )=0A --CblX+4bnyfN0pR09--