public inbox for gentoo-desktop@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alex Efros <powerman@powerman.name>
To: gentoo-desktop@lists.gentoo.org
Subject: [gentoo-desktop] [PATCH] amarok-1.4.10_p20090130-r4 fail to compile
Date: Tue, 27 Sep 2011 18:04:03 +0300	[thread overview]
Message-ID: <20110927150403.GI4290@home.power> (raw)

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

Hi!

Error from build log:

---cut---
In file included from amarokdcophandler.cpp:36:0:
../../../amarok/src/osd.h: At global scope:
../../../amarok/src/osd.h:40:74: error: cannot call constructor 'QImage::QImage' directly
../../../amarok/src/osd.h:40:74: error:   for a function-style cast, remove the redundant '::QImage'
---cut---

Patch (duplicated in attach):

---cut---
--- amarok/src/osd.h.orig       2011-09-27 17:47:26.000000000 +0300
+++ amarok/src/osd.h    2011-09-27 17:47:43.000000000 +0300
@@ -37,7 +37,7 @@
 
       public slots:
         /** calls setText() then show(), after setting image if needed */
-        void show( const QString &text, QImage newImage = QImage::QImage() );
+        void show( const QString &text, QImage newImage = QImage() );
         void ratingChanged( const short rating );
         void ratingChanged( const QString& path, int rating );
         void volChanged( unsigned char volume );
---cut---

I noticed this issue when re-emerging @world after upgrading gcc 4.4.5 to
4.5.3, but probably this issue have nothing with gcc and related to some
previous qt upgrade, so I named patch file amarok-qt3-4.7.patch but I'm
not sure this is correct name.

-- 
			WBR, Alex.

[-- Attachment #2: amarok-qt3-4.7.patch --]
[-- Type: application/x-patch, Size: 561 bytes --]

[-- Attachment #3: amarok-1.4.10_p20090130-r4.ebuild.patch --]
[-- Type: application/x-patch, Size: 483 bytes --]

                 reply	other threads:[~2011-09-27 15:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110927150403.GI4290@home.power \
    --to=powerman@powerman.name \
    --cc=gentoo-desktop@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox