public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Brian Dolbec" <brian.dolbec@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/layman:master commit in: layman/overlays/
Date: Wed, 27 Apr 2011 10:58:45 +0000 (UTC)	[thread overview]
Message-ID: <eab52f261bda8aef53675271357b3ca742f865ad.dol-sen@gentoo> (raw)

commit:     eab52f261bda8aef53675271357b3ca742f865ad
Author:     Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
AuthorDate: Sun Mar 27 07:14:16 2011 +0000
Commit:     Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
CommitDate: Sun Mar 27 07:14:16 2011 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/layman.git;a=commit;h=eab52f26

migrate to explicit if check

---
 layman/overlays/overlay.py |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/layman/overlays/overlay.py b/layman/overlays/overlay.py
index b99c052..9486c38 100644
--- a/layman/overlays/overlay.py
+++ b/layman/overlays/overlay.py
@@ -101,9 +101,9 @@ class Overlay(object):
         self.output = config['output']
         self._encoding_ = get_encoding(self.output)
 
-        if xml:
+        if xml is not None:
             self.from_xml(xml, ignore, quiet)
-        elif ovl_dict:
+        elif ovl_dict is not None:
             self.from_dict(ovl_dict, ignore, quiet)
 
 
@@ -125,7 +125,7 @@ class Overlay(object):
             raise Exception('Overlay is missing a "name" entry!')
 
         _sources = xml.findall('source')
-        if _sources:
+        if _sources != None:
             _sources = [e for e in _sources if 'type' in e.attrib]
         elif ('src' in xml.attrib) and ('type' in xml.attrib):
             s = ET.Element('source', type=xml.attrib['type'])
@@ -242,7 +242,7 @@ class Overlay(object):
 
         _sources = overlay['sources']
 
-        if not _sources:
+        if _sources == None:
             raise Exception('Overlay "' + self.name +
                 '" is missing a "source" entry!')
 
@@ -296,7 +296,7 @@ class Overlay(object):
             self.status = None
 
         self.quality = u'experimental'
-        if overlay['quality']:
+        if len(overlay['quality']):
             if overlay['quality'] in set(QUALITY_LEVELS):
                 self.quality = ensure_unicode(overlay['quality'])
 
@@ -485,7 +485,7 @@ class Overlay(object):
         if self.irc != None:
             result += u'\nIRC : ' + self.irc + u'\n'
 
-        if self.feeds:
+        if len(self.feeds):
             result += u'\n%s:' % ((len(self.feeds) == 1) and "Feed" or "Feeds")
             for i in self.feeds:
                 result += u'\n  %s' % i



             reply	other threads:[~2011-04-27 11:00 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 10:58 Brian Dolbec [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-08-28  3:50 [gentoo-commits] proj/layman:master commit in: layman/overlays/ Devan Franchini
2015-08-28  3:43 Devan Franchini
2015-08-28  0:41 Devan Franchini
2015-08-04  0:23 Devan Franchini
2015-07-21 16:39 Devan Franchini
2015-07-14 15:15 Devan Franchini
2015-07-13 23:05 Devan Franchini
2015-07-13 19:04 Devan Franchini
2015-07-13 18:59 Devan Franchini
2015-07-13 18:52 Devan Franchini
2015-07-13 18:48 Devan Franchini
2015-07-10 16:13 Devan Franchini
2015-03-26 23:47 Devan Franchini
2015-03-26 23:08 Devan Franchini
2015-03-26 18:13 Devan Franchini
2014-12-08  4:15 Devan Franchini
2014-06-16  3:40 Brian Dolbec
2014-06-16  3:40 Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-06-16  3:37 [gentoo-commits] proj/layman:gsoc2014 " Brian Dolbec
2014-06-16  3:40 ` [gentoo-commits] proj/layman:master " Brian Dolbec
2014-03-10  3:18 Brian Dolbec
2013-08-18 16:46 Brian Dolbec
2012-11-01  7:06 Brian Dolbec
2012-10-08  6:16 Brian Dolbec
2012-10-08  4:36 Brian Dolbec
2012-10-07 23:40 Brian Dolbec
2012-01-06  8:16 Brian Dolbec
2011-09-26  1:18 Brian Dolbec
2011-09-24  6:07 Brian Dolbec
2011-09-13 14:16 Brian Dolbec
2011-09-05 16:09 Brian Dolbec
2011-08-07  8:47 Brian Dolbec
2011-08-07  8:39 Brian Dolbec
2011-07-28 21:33 Brian Dolbec
2011-07-23  6:45 Brian Dolbec
2011-05-05  9:44 Brian Dolbec
2011-04-30 22:37 Brian Dolbec
2011-04-30  6:37 Brian Dolbec
2011-04-27 10:58 Brian Dolbec
2011-04-27 10:58 Brian Dolbec
2011-04-27 10:58 Brian Dolbec
2011-04-27 10:58 Brian Dolbec
2011-02-17 21:53 Brian Dolbec
2011-02-14  6:00 Brian Dolbec
2011-02-14  6:00 Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eab52f261bda8aef53675271357b3ca742f865ad.dol-sen@gentoo \
    --to=brian.dolbec@gmail.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox