From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from <gentoo-commits+bounces-335046-garchives=archives.gentoo.org@lists.gentoo.org>) id 1Q90ru-0000Ca-5K for garchives@archives.gentoo.org; Sun, 10 Apr 2011 20:04:22 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BD3451C020; Sun, 10 Apr 2011 20:04:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 9035B1C020 for <gentoo-commits@lists.gentoo.org>; Sun, 10 Apr 2011 20:04:14 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3350A1B409D for <gentoo-commits@lists.gentoo.org>; Sun, 10 Apr 2011 20:04:14 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 86EFD80065 for <gentoo-commits@lists.gentoo.org>; Sun, 10 Apr 2011 20:04:13 +0000 (UTC) From: "Zac Medico" <zmedico@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" <zmedico@gentoo.org> Message-ID: <d0ead65b8019f03bad69d88963ac2aa79a8f7693.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/_emerge/ X-VCS-Repository: proj/portage X-VCS-Files: pym/_emerge/Scheduler.py X-VCS-Directories: pym/_emerge/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: d0ead65b8019f03bad69d88963ac2aa79a8f7693 Date: Sun, 10 Apr 2011 20:04:13 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 9d9280a150e281210f3b26838e93bffd commit: d0ead65b8019f03bad69d88963ac2aa79a8f7693 Author: Zac Medico <zmedico <AT> gentoo <DOT> org> AuthorDate: Sun Apr 10 20:03:11 2011 +0000 Commit: Zac Medico <zmedico <AT> gentoo <DOT> org> CommitDate: Sun Apr 10 20:03:11 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3Dd0ead65b Scheduler: add more info in docstring comments This clarifies the purposes of _system_merge_started and _choose_pkg. --- pym/_emerge/Scheduler.py | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/pym/_emerge/Scheduler.py b/pym/_emerge/Scheduler.py index 06eeed5..d557a14 100644 --- a/pym/_emerge/Scheduler.py +++ b/pym/_emerge/Scheduler.py @@ -1375,6 +1375,10 @@ class Scheduler(PollScheduler): def _system_merge_started(self, merge): """ Add any unsatisfied runtime deps to self._unsatisfied_system_deps. + In general, this keeps track of installed system packages with + unsatisfied RDEPEND or PDEPEND (circular dependencies). It can be + a fragile situation, so we don't execute any unrelated builds until + the circular dependencies are built and intstalled. """ graph =3D self._digraph if graph is None: @@ -1554,7 +1558,9 @@ class Scheduler(PollScheduler): =20 def _choose_pkg(self): """ - Choose a task that has all it's dependencies satisfied. + Choose a task that has all its dependencies satisfied. This is used + for parallel build scheduling, and ensures that we don't build + anything with deep dependencies that have yet to be merged. """ =20 if self._choose_pkg_return_early: