From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1QfH71-00076T-7u for garchives@archives.gentoo.org; Fri, 08 Jul 2011 19:53:19 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 87C6821C084; Fri, 8 Jul 2011 19:53:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 586F521C084 for ; Fri, 8 Jul 2011 19:53:11 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D99661B4040 for ; Fri, 8 Jul 2011 19:53:10 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 937D780042 for ; Fri, 8 Jul 2011 19:53:09 +0000 (UTC) From: "Mike Frysinger" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mike Frysinger" Message-ID: Subject: [gentoo-commits] proj/sandbox:master commit in: libsandbox/ X-VCS-Repository: proj/sandbox X-VCS-Files: libsandbox/libsandbox.c X-VCS-Directories: libsandbox/ X-VCS-Committer: vapier X-VCS-Committer-Name: Mike Frysinger X-VCS-Revision: cb07ed0e23f1b3f3f7efe547f9b60033a429a10a Date: Fri, 8 Jul 2011 19:53:09 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 391d0aaa02a892d4282b5ccec648a983 commit: cb07ed0e23f1b3f3f7efe547f9b60033a429a10a Author: Mike Frysinger gentoo org> AuthorDate: Fri Jul 8 19:52:35 2011 +0000 Commit: Mike Frysinger gentoo org> CommitDate: Fri Jul 8 19:52:35 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/sandbox.git;a= =3Dcommit;h=3Dcb07ed0e libsandbox: invert debug checking order to avoid uninitialized variables We only initialize debug_log_path if debug is set, so we need to check debug first to avoid uninitialized warnings with debug_log_path. Signed-off-by: Mike Frysinger gentoo.org> --- libsandbox/libsandbox.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libsandbox/libsandbox.c b/libsandbox/libsandbox.c index 84191d9..0fcbb65 100644 --- a/libsandbox/libsandbox.c +++ b/libsandbox/libsandbox.c @@ -990,7 +990,7 @@ static int check_syscall(sbcontext_t *sbcontext, int = sb_nr, const char *func, goto error; } =20 - if (debug_log_path && debug) { + if (debug && debug_log_path) { bool worked =3D write_logfile(debug_log_path, func, file, absolute_pat= h, resolved_path, access); if (!worked && errno) goto error;