From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-commits+bounces-416862-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1RlnmE-0005em-If
	for garchives@archives.gentoo.org; Fri, 13 Jan 2012 20:31:07 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id D5CE7E064F;
	Fri, 13 Jan 2012 20:30:57 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id A8FA9E064F
	for <gentoo-commits@lists.gentoo.org>; Fri, 13 Jan 2012 20:30:57 +0000 (UTC)
Received: from pelican.gentoo.org (unknown [66.219.59.40])
	(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPS id 2C2F61B400D
	for <gentoo-commits@lists.gentoo.org>; Fri, 13 Jan 2012 20:30:57 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
	by pelican.gentoo.org (Postfix) with ESMTP id 9E16C80044
	for <gentoo-commits@lists.gentoo.org>; Fri, 13 Jan 2012 20:30:56 +0000 (UTC)
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Robin H. Johnson" <robbat2@gentoo.org>
Message-ID: <b49f1f377db6482aeb4f0a0a717f54632319ded9.robbat2@gentoo>
Subject: [gentoo-commits] proj/genkernel:master commit in: /
X-VCS-Repository: proj/genkernel
X-VCS-Files: ChangeLog gen_determineargs.sh
X-VCS-Directories: /
X-VCS-Committer: robbat2
X-VCS-Committer-Name: Robin H. Johnson
X-VCS-Revision: b49f1f377db6482aeb4f0a0a717f54632319ded9
Date: Fri, 13 Jan 2012 20:30:56 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 0c4a7208-507b-4814-b408-c6f74db4e519
X-Archives-Hash: e26fd2a8ac01adbcfa4a7437a9bb807e

commit:     b49f1f377db6482aeb4f0a0a717f54632319ded9
Author:     Robin H. Johnson <robbat2 <AT> orbis-terrarum <DOT> net>
AuthorDate: Fri Jan 13 20:30:47 2012 +0000
Commit:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
CommitDate: Fri Jan 13 20:30:47 2012 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=3Dproj/genkernel.git=
;a=3Dcommit;h=3Db49f1f37

Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of t=
he usages were of the form "! isTrue ${CMD_NOINSTALL}", which on an unset=
 value, came out as false. These were replaced by "isTrue ${CMD_INSTALL}"=
, but my analysis of the needed default value was wrong, and was set to f=
alse instead of true.

Signed-off-by: Robin H. Johnson <robbat2 <AT> orbis-terrarum.net>

---
 ChangeLog            |    7 +++++++
 gen_determineargs.sh |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8b3c23e..e1a5545 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,13 @@
 # Distributed under the GPL v2
 # $Id$
=20
+  13 Jan 2012; Robin H. Johnson <robbat2@gentoo.org> gen_determineargs.s=
h:
+  Prior to commit a141d715, CMD_NOINSTALL had no default set, but most o=
f the
+  usages were of the form "! isTrue ${CMD_NOINSTALL}", which on an unset=
 value,
+  came out as false. These were replaced by "isTrue ${CMD_INSTALL}", but=
 my
+  analysis of the needed default value was wrong, and was set to false i=
nstead
+  of true.
+
   13 Jan 2012; Sebastian Pipping <sping@gentoo.org> genkernel.conf:
   Replace "# FOO=3Dbar" by "#FOO=3Dbar" in genkernel.conf to (1) disting=
uish
   commented-out options from their explanatory comments and (2) to retur=
n

diff --git a/gen_determineargs.sh b/gen_determineargs.sh
index cd91a27..66f7ee1 100755
--- a/gen_determineargs.sh
+++ b/gen_determineargs.sh
@@ -128,7 +128,7 @@ determine_real_args() {
 	set_config_with_override BOOL   KEYMAP               CMD_KEYMAP        =
       "yes"
 	set_config_with_override BOOL   DOKEYMAPAUTO         CMD_DOKEYMAPAUTO
 	set_config_with_override STRING BUSYBOX_CONFIG       CMD_BUSYBOX_CONFIG
-	set_config_with_override BOOL   INSTALL              CMD_INSTALL       =
       "no"
+	set_config_with_override BOOL   INSTALL              CMD_INSTALL       =
       "yes"
=20
 	BOOTDIR=3D`arch_replace "${BOOTDIR}"`
 	BOOTDIR=3D${BOOTDIR%/}    # Remove any trailing slash