From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RGtQp-0004ZW-5q for garchives@archives.gentoo.org; Thu, 20 Oct 2011 14:17:15 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C5F2721C104; Thu, 20 Oct 2011 14:17:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 97C5A21C104 for ; Thu, 20 Oct 2011 14:17:07 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id DA1651B400F for ; Thu, 20 Oct 2011 14:17:06 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 0D44A80042 for ; Thu, 20 Oct 2011 14:17:06 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/misc-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: a5968f7d9b1c17568fba27f7b7fd284b9431802d Date: Thu, 20 Oct 2011 14:17:06 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 2042bdfe329823f976f0a490c853dd00 commit: a5968f7d9b1c17568fba27f7b7fd284b9431802d Author: Zac Medico gentoo org> AuthorDate: Thu Oct 20 14:16:50 2011 +0000 Commit: Zac Medico gentoo org> CommitDate: Thu Oct 20 14:16:50 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3Da5968f7d misc-functions.sh: move sleep out of loop Having sleep in the world-writable loop causes riduculous delays for prefix users with exotic filesystem constraints (like a FAT filesystem mounted with umask=3D000). --- bin/misc-functions.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index b3e62c5..0d2d206 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -166,14 +166,14 @@ install_qa_check() { fi =20 # Now we look for all world writable files. - local i + local i=3D for i in $(find "${D}/" -type f -perm -2); do vecho "QA Security Notice:" vecho "- ${i:${#D}:${#i}} will be a world writable file." vecho "- This may or may not be a security problem, most of the time i= t is one." vecho "- Please double check that $PF really needs a world writeable b= it and file bugs accordingly." - sleep 1 done + [[ -n ${i} ]] && sleep 1 =20 if type -P scanelf > /dev/null && ! has binchecks ${RESTRICT}; then local qa_var insecure_rpath=3D0 tmp_quiet=3D${PORTAGE_QUIET}