From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Poq7J-0008AM-GW for garchives@archives.gentoo.org; Mon, 14 Feb 2011 04:32:53 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B8C6EE0955; Mon, 14 Feb 2011 04:31:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 7E420E0955 for ; Mon, 14 Feb 2011 04:31:36 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 101FE1B411B for ; Mon, 14 Feb 2011 04:31:36 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 741FE80073 for ; Mon, 14 Feb 2011 04:31:35 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: Subject: [gentoo-commits] proj/portage:2.1.9 commit in: pym/repoman/ X-VCS-Repository: proj/portage X-VCS-Files: pym/repoman/checks.py X-VCS-Directories: pym/repoman/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: a1ead27a48733601cfbac18ef07f1593dbd524d1 Date: Mon, 14 Feb 2011 04:31:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 5928edb28f649516bd8a9e7249d04292 commit: a1ead27a48733601cfbac18ef07f1593dbd524d1 Author: Zac Medico gentoo org> AuthorDate: Sun Feb 13 07:50:08 2011 +0000 Commit: Zac Medico gentoo org> CommitDate: Mon Feb 14 04:26:40 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3Da1ead27a repoman: variable.usedwithhelpers ignore comments This will fix bug #354685. --- pym/repoman/checks.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 7e5a8a1..8f61c07 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -333,7 +333,7 @@ class NoOffsetWithHelpers(LineCheck): helpers """ =20 repoman_check_name =3D 'variable.usedwithhelpers' - re =3D re.compile(r'.*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D= |ROOT|ED|EROOT|EPREFIX)\}?.*') + re =3D re.compile(r'^[^#]*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\= {?(D|ROOT|ED|EROOT|EPREFIX)\}?.*') error =3D errors.NO_OFFSET_WITH_HELPERS =20 class ImplicitRuntimeDeps(LineCheck):