[gentoo-commits] portage r15219 - in main/branches/prefix/pym: portage repoman

[gentoo-commits] portage r15219 - in main/branches/prefix/pym: portage repoman

[Fabian Groffen (grobian)]

Author: grobian
Date: 2010-01-29 18:02:04 +0000 (Fri, 29 Jan 2010)
New Revision: 15219

Modified:
   main/branches/prefix/pym/portage/__init__.py
   main/branches/prefix/pym/repoman/utilities.py
Log:
   Merged from trunk -r15214:15218

   | 15216   | Move the DOM unlink call to a finally block.                 |
   | zmedico |                                                              |
   
   | 15217   | Bug #300378 - Don't export FILESDIR to the 'depend' phase.   |
   | zmedico |                                                              |
   
   | 15218   | In portage.spawn(), apply group write permission to the log  |
   | zmedico | file.                                                        |


Modified: main/branches/prefix/pym/portage/__init__.py
===================================================================
--- main/branches/prefix/pym/portage/__init__.py	2010-01-29 17:53:39 UTC (rev 15218)
+++ main/branches/prefix/pym/portage/__init__.py	2010-01-29 18:02:04 UTC (rev 15219)
@@ -3797,6 +3797,9 @@
 		if eapi not in ("0", "1", "2", "3", "3_pre2"):
 			mydict.pop("AA", None)
 
+		if phase == 'depend':
+			mydict.pop('FILESDIR', None)
+
 		return mydict
 
 	def thirdpartymirrors(self):
@@ -4171,6 +4174,8 @@
 
 	if logfile:
 		log_file = open(_unicode_encode(logfile), mode='ab')
+		apply_secpass_permissions(logfile,
+			uid=portage_uid, gid=portage_gid, mode=0o664)
 		stdout_file = os.fdopen(os.dup(fd_pipes_orig[1]), 'wb')
 		master_file = os.fdopen(master_fd, 'rb')
 		iwtd = [master_file]

Modified: main/branches/prefix/pym/repoman/utilities.py
===================================================================
--- main/branches/prefix/pym/repoman/utilities.py	2010-01-29 17:53:39 UTC (rev 15218)
+++ main/branches/prefix/pym/repoman/utilities.py	2010-01-29 18:02:04 UTC (rev 15219)
@@ -124,28 +124,30 @@
 		raise exception.ParseError("metadata.xml: %s" % (e,))
 
 	try:
-		usetag = metadatadom.getElementsByTagName("use")
-		if not usetag:
+
+		try:
+			usetag = metadatadom.getElementsByTagName("use")
+			if not usetag:
+				return uselist
+		except NotFoundErr:
 			return uselist
-	except NotFoundErr:
-		return uselist
 
-	try:
-		flags = usetag[0].getElementsByTagName("flag")
-	except NotFoundErr:
-		raise exception.ParseError("metadata.xml: " + \
-			"Malformed input: missing 'flag' tag(s)")
-
-	for flag in flags:
-		pkg_flag = flag.getAttribute("name")
-		if not pkg_flag:
+		try:
+			flags = usetag[0].getElementsByTagName("flag")
+		except NotFoundErr:
 			raise exception.ParseError("metadata.xml: " + \
-				"Malformed input: missing 'name' attribute for 'flag' tag")
-		uselist.append(pkg_flag)
+				"Malformed input: missing 'flag' tag(s)")
 
-	metadatadom.unlink()
-	return uselist
+		for flag in flags:
+			pkg_flag = flag.getAttribute("name")
+			if not pkg_flag:
+				raise exception.ParseError("metadata.xml: " + \
+					"Malformed input: missing 'name' attribute for 'flag' tag")
+			uselist.append(pkg_flag)
+		return uselist
 
+	finally:
+		metadatadom.unlink()
 
 def FindPackagesToScan(settings, startdir, reposplit):
 	""" Try to find packages that need to be scanned