public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] portage r14218 - main/trunk/bin
@ 2009-09-08  9:11 Zac Medico (zmedico)
  0 siblings, 0 replies; only message in thread
From: Zac Medico (zmedico) @ 2009-09-08  9:11 UTC (permalink / raw
  To: gentoo-commits

Author: zmedico
Date: 2009-09-08 09:11:35 +0000 (Tue, 08 Sep 2009)
New Revision: 14218

Modified:
   main/trunk/bin/misc-functions.sh
Log:
Fix false positives in gcc QA with debug mode some more. Thanks again to
Amit Dor-Shifer <amitds@oversi.com> for reporting.


Modified: main/trunk/bin/misc-functions.sh
===================================================================
--- main/trunk/bin/misc-functions.sh	2009-09-08 08:10:10 UTC (rev 14217)
+++ main/trunk/bin/misc-functions.sh	2009-09-08 09:11:35 UTC (rev 14218)
@@ -408,8 +408,8 @@
 
 	# Evaluate misc gcc warnings
 	if [[ -n ${PORTAGE_LOG_FILE} && -r ${PORTAGE_LOG_FILE} ]] ; then
-		# In debug mode, this variable definition will produce
-		# a false positive if it's shown in the trace.
+		# In debug mode, this variable definition and corresponding grep calls
+		# will produce false positives if they're shown in the trace.
 		local reset_debug=0
 		if [[ ${-/x/} != $- ]] ; then
 			set +x
@@ -424,7 +424,6 @@
 			": warning: comparisons like X<=Y<=Z do not have their mathematical meaning$"
 			": warning: null argument where non-null required "
 		)
-		[[ $reset_debug = 1 ]] && set -x
 		abort="no"
 		i=0
 		while [[ -n ${msgs[${i}]} ]] ; do
@@ -440,6 +439,7 @@
 				abort="yes"
 			fi
 		done
+		[[ $reset_debug = 1 ]] && set -x
 		f=$(cat "${PORTAGE_LOG_FILE}" | \
 			"$PORTAGE_BIN_PATH"/check-implicit-pointer-usage.py)
 		if [[ -n ${f} ]] ; then




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-08  9:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-08  9:11 [gentoo-commits] portage r14218 - main/trunk/bin Zac Medico (zmedico)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox