[gentoo-commits] devmanual r146 - in trunk/ebuild-writing: functions/pkg_preinst users-and-groups

[gentoo-commits] devmanual r146 - in trunk/ebuild-writing: functions/pkg_preinst users-and-groups

[Mark Loeser (halcy0n)]

Author: halcy0n
Date: 2009-04-19 21:04:16 +0000 (Sun, 19 Apr 2009)
New Revision: 146

Modified:
   trunk/ebuild-writing/functions/pkg_preinst/text.xml
   trunk/ebuild-writing/users-and-groups/text.xml
Log:
Clarify user creation in pkg_preinst, thanks to Thilo Bangert <bangert AT gentoo DOT org> for the patch; bug #155620


Modified: trunk/ebuild-writing/functions/pkg_preinst/text.xml
===================================================================
--- trunk/ebuild-writing/functions/pkg_preinst/text.xml	2009-04-08 14:34:55 UTC (rev 145)
+++ trunk/ebuild-writing/functions/pkg_preinst/text.xml	2009-04-19 21:04:16 UTC (rev 146)
@@ -61,7 +61,9 @@
 
 <ul>
   <li>
-  Adding users and groups <d/> see <uri link="::ebuild-writing/users-and-groups"/>.
+  Adding users and groups. However, since <c>pkg_preinst</c> may be called 
+  after <c>src_compile</c>, <c>pkg_setup</c> is the more suitable location for
+  user creation <d/> see <uri link="::ebuild-writing/users-and-groups"/>.
   </li>
   <li>
   Modifying the install image for a particular system. This function

Modified: trunk/ebuild-writing/users-and-groups/text.xml
===================================================================
--- trunk/ebuild-writing/users-and-groups/text.xml	2009-04-08 14:34:55 UTC (rev 145)
+++ trunk/ebuild-writing/users-and-groups/text.xml	2009-04-19 21:04:16 UTC (rev 146)
@@ -8,9 +8,11 @@
 If your ebuild requires a user or group to be added for a daemon, for example,
 this should be performed via the functions available in <c>eutils.eclass</c>.
 Regardless of whether you are adding a group or a user, this should be performed
-in the <c>pkg_setup</c> function and <b>not</b> somewhere else: pkg_setup is sandbox-safe,
+in the <c>pkg_setup</c> function: <c>pkg_setup</c> is sandbox-safe,
 is called before the compile process so a build that requires the user to exist will
-have it, and is also called for both binary and source packages.
+have it, and is also called for both binary and source packages. You may also 
+use the <c>pkg_preinst</c> or <c>pkg_setup</c> functions for user creation, if
+the user is not required during <c>src_compile</c>.
 </p>
 </body>