public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico (zmedico)" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] portage r12095 - main/branches/2.1.6/bin
Date: Wed, 26 Nov 2008 06:25:55 +0000	[thread overview]
Message-ID: <E1L5DqV-0002nE-Mx@stork.gentoo.org> (raw)

Author: zmedico
Date: 2008-11-26 06:25:55 +0000 (Wed, 26 Nov 2008)
New Revision: 12095

Modified:
   main/branches/2.1.6/bin/repoman
Log:
Bug #248464 - With git, there's never any keyword expansion, so there's
no need to regenerate manifests and all files will be committed in one
big commit at the end. (trunk r12094)


Modified: main/branches/2.1.6/bin/repoman
===================================================================
--- main/branches/2.1.6/bin/repoman	2008-11-26 06:24:25 UTC (rev 12094)
+++ main/branches/2.1.6/bin/repoman	2008-11-26 06:25:55 UTC (rev 12095)
@@ -1795,8 +1795,16 @@
 		if myout[0] == 0:
 			myheaders.append(myfile)
 
-	print "*",green(str(len(myupdates))),"files being committed...",green(str(len(myheaders))),"have headers that will change."
-	print "*","Files with headers will cause the manifests to be made and recommited."
+	print "* %s files being committed..." % green(str(len(myupdates))),
+	if vcs == 'git':
+		# With git, there's never any keyword expansion, so there's
+		# no need to regenerate manifests and all files will be
+		# committed in one big commit at the end.
+		print
+	else:
+		print "%s have headers that will change." % green(str(len(myheaders)))
+		print "* Files with headers will cause the " + \
+			"manifests to be made and recommited."
 	logging.info("myupdates:", str(myupdates))
 	logging.info("myheaders:", str(myheaders))
 
@@ -1844,7 +1852,7 @@
 		commitmessage += ", RepoMan options: --force"
 	commitmessage += ")"
 
-	if myupdates or myremoved:
+	if vcs != 'git' and (myupdates or myremoved):
 		myfiles = myupdates + myremoved
 		if not myheaders and "sign" not in repoman_settings.features:
 			myfiles += mymanifests
@@ -1937,7 +1945,7 @@
 			write_atomic(x, "".join(mylines))
 
 	manifest_commit_required = True
-	if myupdates or myremoved or mynew:
+	if vcs != 'git' and (myupdates or myremoved or mynew):
 		myfiles=myupdates+myremoved+mynew
 		for x in range(len(myfiles)-1, -1, -1):
 			if myfiles[x].count("/") < 4-repolevel:
@@ -2059,8 +2067,14 @@
 			portage.writemsg("!!! Disabled FEATURES='sign'\n")
 			signed = False
 
-	if manifest_commit_required or signed:
+	if vcs == 'git' or manifest_commit_required or signed:
 
+		myfiles = mymanifests[:]
+		if vcs == 'git':
+			myfiles += myupdates
+			myfiles += myremoved
+		myfiles.sort()
+
 		fd, commitmessagefile = tempfile.mkstemp(".repoman.msg")
 		mymsg = os.fdopen(fd, "w")
 		mymsg.write(commitmessage)
@@ -2075,7 +2089,7 @@
 		commit_cmd.append("commit")
 		commit_cmd.extend(vcs_local_opts)
 		commit_cmd.extend(["-F", commitmessagefile])
-		commit_cmd.extend(f.lstrip("./") for f in mymanifests)
+		commit_cmd.extend(f.lstrip("./") for f in myfiles)
 
 		try:
 			if options.pretend:




                 reply	other threads:[~2008-11-26  6:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1L5DqV-0002nE-Mx@stork.gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox