From: "Zac Medico (zmedico)" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] portage r11480 - main/trunk/pym/repoman
Date: Sun, 31 Aug 2008 07:13:55 +0000 [thread overview]
Message-ID: <E1KZh8F-00031C-Ln@stork.gentoo.org> (raw)
Author: zmedico
Date: 2008-08-31 07:13:54 +0000 (Sun, 31 Aug 2008)
New Revision: 11480
Modified:
main/trunk/pym/repoman/checks.py
main/trunk/pym/repoman/errors.py
Log:
Add a warning for emake -j1 calls which disable parallelization. Thanks to
Diego "Flameeyes" Petten?\195?\178 for the suggestion.
Modified: main/trunk/pym/repoman/checks.py
===================================================================
--- main/trunk/pym/repoman/checks.py 2008-08-30 21:43:52 UTC (rev 11479)
+++ main/trunk/pym/repoman/checks.py 2008-08-31 07:13:54 UTC (rev 11480)
@@ -268,12 +268,19 @@
if self._iuse_def is None:
yield 'IUSE is not defined'
+class EMakeParallelDisabled(LineCheck):
+ """Check for emake -j1 calls which disable parallelization."""
+ repoman_check_name = 'ebuild.minorsyn'
+ re = re.compile(r'^\s*emake\s*-j\s*1\s')
+ error = errors.EMAKE_PARALLEL_DISABLED
+
_constant_checks = tuple((c() for c in (
EbuildHeader, EbuildWhitespace, EbuildQuote,
EbuildAssignment, EbuildUselessDodoc,
EbuildUselessCdS, EbuildNestedDie,
EbuildPatches, EbuildQuotedA,
- IUseUndefined, InheritAutotools)))
+ IUseUndefined, InheritAutotools,
+ EMakeParallelDisabled)))
def run_checks(contents, pkg):
checks = _constant_checks
Modified: main/trunk/pym/repoman/errors.py
===================================================================
--- main/trunk/pym/repoman/errors.py 2008-08-30 21:43:52 UTC (rev 11479)
+++ main/trunk/pym/repoman/errors.py 2008-08-31 07:13:54 UTC (rev 11480)
@@ -13,3 +13,4 @@
NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d'
PATCHES_ERROR = 'PATCHES is not a bash array on line: %d'
REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
+EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d'
reply other threads:[~2008-08-31 7:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KZh8F-00031C-Ln@stork.gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox