[gentoo-commits] gentoo commit in src/patchsets/vlc/0.9.0: 320_all_zdefs.patch series

[gentoo-commits] gentoo commit in src/patchsets/vlc/0.9.0: 320_all_zdefs.patch series

[Alexis Ballier (aballier)]

aballier    08/05/22 16:31:27

  Modified:             series
  Added:                320_all_zdefs.patch
  Log:
  I prefer using -z,defs for now in order to spot problems at build time rather than failing silently and losing features at runtime

Revision  Changes    Path
1.4                  src/patchsets/vlc/0.9.0/series

file : http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?rev=1.4&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?rev=1.4&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?r1=1.3&r2=1.4

Index: series
===================================================================
RCS file: /var/cvsroot/gentoo/src/patchsets/vlc/0.9.0/series,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- series	2 Jan 2008 00:33:51 -0000	1.3
+++ series	22 May 2008 16:31:26 -0000	1.4
@@ -4,3 +4,4 @@
 250_all_livepic.patch
 300_all_pic.patch
 310_all_mmx_pic.patch
+320_all_zdefs.patch



1.1                  src/patchsets/vlc/0.9.0/320_all_zdefs.patch

file : http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/320_all_zdefs.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/320_all_zdefs.patch?rev=1.1&content-type=text/plain

Index: 320_all_zdefs.patch
===================================================================
commit e8bb480ea9b9cac675c5ab510f4eabcb8ecce375
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Thu May 22 17:49:01 2008 +0200

    Revert "Remove the forced ld -z,defs flags."
    
    This reverts commit 074ed6708644323bd441332fb7d34b99bd954350.
    
    Useful to avoid runtime errors, it's better to spot them at build time.

Index: vlc-0.9.0-git/configure.ac
===================================================================
--- vlc-0.9.0-git.orig/configure.ac
+++ vlc-0.9.0-git/configure.ac
@@ -984,6 +984,15 @@ CFLAGS="${CFLAGS_save}"
 RDC_PROG_CC_WFLAGS([all extra sign-compare undef pointer-arith bad-function-cast cast-align write-strings missing-prototypes volatile-register-var])
 RDC_PROG_CC_FLAGS_IFELSE([-pipe])
 
+dnl This helps detect broken plugins with undefined symbols
+dnl Better fail loudly at build-time than silenty at run-time.
+dnl Unfortunately, this sucks on FreeBSD (won't even link with -lc)
+if test `uname -s` != FreeBSD; then
+  RDC_PROG_LINK_FLAGS_IFELSE([-Wl,-z,defs], [
+    VLC_ADD_LDFLAGS([plugin],[-Wl,-z,defs])
+  ])
+fi
+
 dnl Check for various optimization flags
 AC_CACHE_CHECK([if \$CC accepts -Os],
     [ac_cv_c_os],



-- 
gentoo-commits@lists.gentoo.org mailing list

[gentoo-commits] gentoo commit in src/patchsets/vlc/0.9.0: 320_all_zdefs.patch series

[Alexis Ballier (aballier)]

aballier    08/07/14 11:21:57

  Modified:             series
  Removed:              320_all_zdefs.patch
  Log:
  drop the z defs patch

Revision  Changes    Path
1.6                  src/patchsets/vlc/0.9.0/series

file : http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?rev=1.6&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?rev=1.6&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo/src/patchsets/vlc/0.9.0/series?r1=1.5&r2=1.6

Index: series
===================================================================
RCS file: /var/cvsroot/gentoo/src/patchsets/vlc/0.9.0/series,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- series	21 Jun 2008 08:03:57 -0000	1.5
+++ series	14 Jul 2008 11:21:56 -0000	1.6
@@ -3,4 +3,3 @@
 250_all_livepic.patch
 300_all_pic.patch
 310_all_mmx_pic.patch
-320_all_zdefs.patch



-- 
gentoo-commits@lists.gentoo.org mailing list