[gentoo-commits] gentoo-x86 commit in eclass: flag-o-matic.eclass

["Diego Petteno (flameeyes)" <flameeyes@gentoo.org>]

flameeyes    08/06/07 16:42:32

  Modified:             flag-o-matic.eclass
  Log:
  Warn when using append-ldflags to pass libraries to link to.
  
  Libraries shouldn't be passed as LDFLAGS, the flags should be passed
  before the object files to link, while libraries should be passed
  after. Passing libraries through LDFLAGS is one of the causes of
  --as-needed failures.

Revision  Changes    Path
1.123                eclass/flag-o-matic.eclass

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.123&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.123&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.122&r2=1.123

Index: flag-o-matic.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v
retrieving revision 1.122
retrieving revision 1.123
diff -u -r1.122 -r1.123
--- flag-o-matic.eclass	18 Feb 2008 18:20:47 -0000	1.122
+++ flag-o-matic.eclass	7 Jun 2008 16:42:32 -0000	1.123
@@ -1,6 +1,6 @@
 # Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.122 2008/02/18 18:20:47 swegener Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.123 2008/06/07 16:42:32 flameeyes Exp $
 
 # @ECLASS: flag-o-matic.eclass
 # @MAINTAINER:
@@ -579,6 +579,12 @@
 # Add extra <flags> to the current LDFLAGS.
 append-ldflags() {
 	[[ -z $* ]] && return 0
+	local flag
+	for flag in "$@"; do
+		[[ ${flag} == -l* ]] && \
+			ewarn "Appending a library link instruction (${flag}); libraries to link to should not be passed through LDFLAGS"
+	done
+
 	export LDFLAGS="${LDFLAGS} $*"
 	return 0
 }



-- 
gentoo-commits@lists.gentoo.org mailing list