public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [gentoo-commits] gentoo-x86 commit in mail-client/mutt/files: mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch
@ 2009-07-02  8:44 99% Fabian Groffen (grobian)
  0 siblings, 0 replies; 1+ results
From: Fabian Groffen (grobian) @ 2009-07-02  8:44 UTC (permalink / raw
  To: gentoo-commits

grobian     09/07/02 08:44:34

  Added:               
                        mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch
  Log:
  Bump for patch to fix bug #276101, regarding smtp batching with authentication.
  (Portage version: 2.1.6.13/cvs/Linux x86_64)

Revision  Changes    Path
1.1                  mail-client/mutt/files/mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/mail-client/mutt/files/mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/mail-client/mutt/files/mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch?rev=1.1&content-type=text/plain

Index: mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch
===================================================================
http://dev.mutt.org/trac/changeset/0a3de4d9a009

SMTP: use $smtp_pass in batch mode. Closes #3289.

mutt_account_getpass() copying the password from $smtp_pass into the
account structure is only called from the SASL callback we only use if
we're sure we don't need curses (i.e. have the pass already).

http://dev.mutt.org/trac/changeset/f6c6066a5925

Make getuser/pass abort if input is required in batch mode.
Replaces [0a3de4d9a009]. See #3289.


Index: account.c
===================================================================
--- account.c (revision 5557:6c58b678d360)
+++ account.c (revision 5965:f6c6066a5925)
@@ -156,4 +156,6 @@
     strfcpy (account->user, PopUser, sizeof (account->user));
 #endif
+  else if (option (OPTNOCURSES))
+    return -1;
   /* prompt (defaults to unix username), copy into account->user */
   else
@@ -216,4 +218,6 @@
     strfcpy (account->pass, SmtpPass, sizeof (account->pass));
 #endif
+  else if (option (OPTNOCURSES))
+    return -1;
   else
   {
Index: mutt_sasl.c
===================================================================
--- mutt_sasl.c (revision 5711:6fac57b97bf1)
+++ mutt_sasl.c (revision 5965:f6c6066a5925)
@@ -305,5 +305,5 @@
     snprintf (prompt, sizeof (prompt), "%s: ", interaction->prompt);
     resp[0] = '\0';
-    if (mutt_get_field (prompt, resp, sizeof (resp), 0))
+    if (option (OPTNOCURSES) || mutt_get_field (prompt, resp, sizeof (resp), 0))
       return SASL_FAIL;
 
Index: smtp.c
===================================================================
--- smtp.c (revision 5963:0a3de4d9a009)
+++ smtp.c (revision 5965:f6c6066a5925)
@@ -173,5 +173,5 @@
   struct stat st;
   int r, term = 0;
-  size_t buflen;
+  size_t buflen = 0;
 
   fp = fopen (msgfile, "r");
@@ -461,10 +455,4 @@
 
 #ifdef USE_SASL
-    if (!(conn->account.flags & M_ACCT_PASS) && option (OPTNOCURSES))
-    {
-      mutt_error (_("Interactive SMTP authentication not supported"));
-      mutt_sleep (1);
-      return -1;
-    }
     return smtp_auth (conn);
 #else
@@ -610,5 +598,5 @@
     }
     strfcpy (buf + len, "\r\n", sizeof (buf) - len);
-  } while (rc == smtp_ready);
+  } while (rc == smtp_ready && saslrc != SASL_FAIL);
 
   if (smtp_success (rc))






^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2009-07-02  8:44 99% [gentoo-commits] gentoo-x86 commit in mail-client/mutt/files: mutt-1.5.20-smtp-batch-mode-0a3de4d9a009-f6c6066a5925.patch Fabian Groffen (grobian)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox