* [gentoo-commits] gentoo-x86 commit in media-radio/xlog/files: xlog-2.0.3-memmove.patch
@ 2010-10-04 15:19 99% Thomas Beierlein (tomjbe)
0 siblings, 0 replies; 1+ results
From: Thomas Beierlein (tomjbe) @ 2010-10-04 15:19 UTC (permalink / raw
To: gentoo-commits
tomjbe 10/10/04 15:19:36
Added: xlog-2.0.3-memmove.patch
Log:
Fix buffer overflow (bug #339652). Thanks for reporting Diego.
(Portage version: 2.1.9.13/cvs/Linux x86_64)
Revision Changes Path
1.1 media-radio/xlog/files/xlog-2.0.3-memmove.patch
file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-radio/xlog/files/xlog-2.0.3-memmove.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-radio/xlog/files/xlog-2.0.3-memmove.patch?rev=1.1&content-type=text/plain
Index: xlog-2.0.3-memmove.patch
===================================================================
diff -Nur src/logfile.old/oh1aa.c src/logfile/oh1aa.c
--- src/logfile.old/oh1aa.c 2010-10-04 15:03:52.000000000 +0000
+++ src/logfile/oh1aa.c 2010-10-04 15:05:13.000000000 +0000
@@ -111,25 +111,25 @@
//0502201751OK2BMA 59 59 28 MHzSSB pavel 0
/* insert a space between date and time */
- memmove (buffer+7, buffer+6, MAXROWLEN);
+ memmove (buffer+7, buffer+6, MAXROWLEN-7);
buffer[6] = ' ';
/* insert a space between time and call */
- memmove (buffer+12, buffer+11, MAXROWLEN);
+ memmove (buffer+12, buffer+11, MAXROWLEN-12);
buffer[11] = ' ';
/* insert a space between call and myrst */
- memmove (buffer+24, buffer+23, MAXROWLEN);
+ memmove (buffer+24, buffer+23, MAXROWLEN-24);
buffer[24] = ' ';
/* insert a space between myrst and rst */
- memmove (buffer+28, buffer+27, MAXROWLEN);
+ memmove (buffer+28, buffer+27, MAXROWLEN-28);
buffer[28] = ' ';
/* insert a space between rst and band */
- memmove (buffer+32, buffer+31, MAXROWLEN);
+ memmove (buffer+32, buffer+31, MAXROWLEN-32);
buffer[32] = ' ';
/* insert a space between band and mode */
- memmove (buffer+40, buffer+39, MAXROWLEN);
+ memmove (buffer+40, buffer+39, MAXROWLEN-40);
buffer[40] = ' ';
/* insert a space between mode and remarks */
- memmove (buffer+45, buffer+44, MAXROWLEN);
+ memmove (buffer+45, buffer+44, MAXROWLEN-45);
buffer[45] = ' ';
for (i = 0; i < oh1aa_field_nr; i++)
diff -Nur src/logfile.old/trlog.c src/logfile/trlog.c
--- src/logfile.old/trlog.c 2010-10-04 15:03:52.000000000 +0000
+++ src/logfile/trlog.c 2010-10-04 15:04:21.000000000 +0000
@@ -195,7 +195,7 @@
continue;
/* insert a space between band and mode */
- memmove (buffer+4, buffer+3, MAXROWLEN);
+ memmove (buffer+4, buffer+3, MAXROWLEN-4);
buffer[3] = ' ';
for (i = 0; i < trlog_field_nr - 1; i++)
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2010-10-04 15:19 99% [gentoo-commits] gentoo-x86 commit in media-radio/xlog/files: xlog-2.0.3-memmove.patch Thomas Beierlein (tomjbe)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox