public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [gentoo-commits] proj/qt:master commit in: eclass/
@ 2016-05-30  0:40 99% Davide Pesavento
  0 siblings, 0 replies; 1+ results
From: Davide Pesavento @ 2016-05-30  0:40 UTC (permalink / raw
  To: gentoo-commits

commit:     cb6166dae65059db60215c4ff61e5547df862931
Author:     Davide Pesavento <pesa <AT> gentoo <DOT> org>
AuthorDate: Mon May 30 00:23:00 2016 +0000
Commit:     Davide Pesavento <pesa <AT> gentoo <DOT> org>
CommitDate: Mon May 30 00:39:58 2016 +0000
URL:        https://gitweb.gentoo.org/proj/qt.git/commit/?id=cb6166da

qt5-build.eclass: make sure we enable the QML debugging support

The code comment was incorrect, the flag *is* used, at least in Qt 5.6
and later. It obviously applies only to qtdeclarative, but for some
reason the flag can only be toggled from qtbase's configure... meh.

We don't allow turning this functionality off via a USE flag because
it would be a mess to implement properly, and its meaning would be
rather obscure for most users. It's a small amount of code anyway, and
it doesn't require any additional dependencies.

The configure already enabled -qml-debug by default, so this commit
effectively doesn't change anything in practice.

 eclass/qt5-build.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/qt5-build.eclass b/eclass/qt5-build.eclass
index 9732058..349e551 100644
--- a/eclass/qt5-build.eclass
+++ b/eclass/qt5-build.eclass
@@ -547,8 +547,8 @@ qt5_base_configure() {
 		-no-sql-db2 -no-sql-ibase -no-sql-mysql -no-sql-oci -no-sql-odbc
 		-no-sql-psql -no-sql-sqlite -no-sql-sqlite2 -no-sql-tds
 
-		# obsolete flag, does nothing
-		#-qml-debug
+		# ensure the QML debugging support (qmltooling) is built in qtdeclarative
+		$([[ ${QT5_MINOR_VERSION} -ge 6 ]] && echo -qml-debug)
 
 		# MIPS DSP instruction set extensions
 		$(is-flagq -mno-dsp   && echo -no-mips_dsp)


^ permalink raw reply related	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-05-30  0:40 99% [gentoo-commits] proj/qt:master commit in: eclass/ Davide Pesavento

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox