public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Alexandre Restovtsev" <tetromino@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gnome:gnome-next commit in: eclass/
Date: Tue, 20 Sep 2011 02:16:50 +0000 (UTC)	[thread overview]
Message-ID: <765007b63d0c4e9c9e81eabaf79ce87f87da1720.tetromino@gentoo> (raw)

commit:     765007b63d0c4e9c9e81eabaf79ce87f87da1720
Author:     Alexandre Rostovtsev <tetromino <AT> gmail <DOT> com>
AuthorDate: Tue Sep 20 02:12:30 2011 +0000
Commit:     Alexandre Restovtsev <tetromino <AT> gmail <DOT> com>
CommitDate: Tue Sep 20 02:12:30 2011 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commit;h=765007b6

eclass/gnome2-live.eclass: fix autopoint logic

Borrow the logic from gnome-autogen.sh to only run autopoint for
packages that use AM_GNU_GETTEXT_VERSION and do not use
AM_GLIB_GNU_GETTEXT. Otherwise, running autopoint will result in
failures such as

autopoint: *** Missing version: please specify in configure.in through a
line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package
is using

Thanks to Steev Klimaszewski for pointing out such a failure on IRC.

The eclass now appears to work both for packages that require autopoint
(e.g. cogl) and those that cannot use it (e.g. mutter).

---
 eclass/gnome2-live.eclass |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/eclass/gnome2-live.eclass b/eclass/gnome2-live.eclass
index 6c4aefd..638cdc9 100644
--- a/eclass/gnome2-live.eclass
+++ b/eclass/gnome2-live.eclass
@@ -81,13 +81,16 @@ gnome2-live_src_prepare() {
 		mkdir -p "$i"
 	done
 
-	# Generate po/Makefile.in.in if it doesn't exist
-	if [[ -d po && ! -e po/Makefile.in.in && ! -e po/Makefile.am ]]; then
-		eautopoint --force
-	fi
-
 	# We don't run gettextize because that does too much stuff
 	if grep -qe 'GETTEXT' configure.*; then
+		# Generate po/Makefile.in.in if it doesn't exist for packages that use
+		# AM_GNU_GETTEXT and AM_GNU_GETTEXT_VERSION (e.g. media-libs/cogl).
+		# Logic is inspired by gnome-autogen.sh
+		if ! grep -qe '^AM_GLIB_GNU_GETTEXT' configure.* &&
+		   grep -qe '^AM_GNU_GETTEXT_VERSION' configure.* &&
+		   [[ -d po && ! -e po/Makefile.in.in && ! -e po/Makefile.am ]]; then
+			eautopoint --force
+		fi
 		local aux_dir=${S}/$(gnome2-live_get_var AC_CONFIG_AUX_DIR configure.*)
 		mkdir -p "${aux_dir}"
 		test -e "${aux_dir}/config.rpath" || :> "${aux_dir}/config.rpath"



             reply	other threads:[~2011-09-20  2:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20  2:16 Alexandre Restovtsev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-03-01 22:51 [gentoo-commits] proj/gnome:gnome-next commit in: eclass/ Gilles Dartiguelongue
2011-09-27 13:36 Nirbheek Chauhan
2011-09-26  4:46 Alexandre Restovtsev
2011-09-25 20:33 Alexandre Restovtsev
2011-09-19 23:22 Alexandre Restovtsev
2011-08-28 18:46 Alexandre Restovtsev
2011-08-24 16:32 Alexandre Restovtsev
2011-08-21  7:10 Alexandre Restovtsev
2011-07-19  0:22 Alexandre Restovtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=765007b63d0c4e9c9e81eabaf79ce87f87da1720.tetromino@gentoo \
    --to=tetromino@gmail.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox