From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RH4m3-00035a-SO for garchives@archives.gentoo.org; Fri, 21 Oct 2011 02:23:56 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D6EEA21C081; Fri, 21 Oct 2011 02:23:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A3A6821C081 for ; Fri, 21 Oct 2011 02:23:48 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 305F61B400D for ; Fri, 21 Oct 2011 02:23:48 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 9900980042 for ; Fri, 21 Oct 2011 02:23:47 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <44a03c9f2218ae7cfdc03aae495d255e0ca2e5b1.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/misc-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 44a03c9f2218ae7cfdc03aae495d255e0ca2e5b1 Date: Fri, 21 Oct 2011 02:23:47 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 0d7128377105e69832b81956a6081dc1 commit: 44a03c9f2218ae7cfdc03aae495d255e0ca2e5b1 Author: Zac Medico gentoo org> AuthorDate: Fri Oct 21 02:19:28 2011 +0000 Commit: Zac Medico gentoo org> CommitDate: Fri Oct 21 02:19:28 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3D44a03c9f misc-functions.sh: condense world-writable output --- bin/misc-functions.sh | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index 0d2d206..55d9663 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -144,7 +144,7 @@ prepcompress() { } =20 install_qa_check() { - local f x + local f i x =20 cd "${D}" || die "cd failed" =20 @@ -166,14 +166,14 @@ install_qa_check() { fi =20 # Now we look for all world writable files. - local i=3D - for i in $(find "${D}/" -type f -perm -2); do - vecho "QA Security Notice:" - vecho "- ${i:${#D}:${#i}} will be a world writable file." + local unsafe_files=3D$(find "${D}" -type f -perm -2 | sed -e "s:^${D}:-= :") + if [[ -n ${unsafe_files} ]] ; then + vecho "QA Security Notice: world writable file(s):" + vecho "${unsafe_files}" vecho "- This may or may not be a security problem, most of the time i= t is one." vecho "- Please double check that $PF really needs a world writeable b= it and file bugs accordingly." - done - [[ -n ${i} ]] && sleep 1 + sleep 1 + fi =20 if type -P scanelf > /dev/null && ! has binchecks ${RESTRICT}; then local qa_var insecure_rpath=3D0 tmp_quiet=3D${PORTAGE_QUIET}