public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Petteri Räty" <betelgeuse@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/libbash:master commit in: bashast/, bashast/gunit/
Date: Thu,  4 Aug 2011 13:53:41 +0000 (UTC)	[thread overview]
Message-ID: <4241b112b64937a27b4ff04917fe6f497e98c123.betelgeuse@gentoo> (raw)

commit:     4241b112b64937a27b4ff04917fe6f497e98c123
Author:     Mu Qiao <qiaomuf <AT> gentoo <DOT> org>
AuthorDate: Fri Jul 22 07:48:16 2011 +0000
Commit:     Petteri Räty <betelgeuse <AT> gentoo <DOT> org>
CommitDate: Tue Aug  2 07:46:29 2011 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/libbash.git;a=commit;h=4241b112

Parser: fix the rule for expansion pattern

---
 bashast/bashast.g              |   60 +++++++++++++++++++++++----------------
 bashast/gunit/param_main.gunit |    3 ++
 2 files changed, 38 insertions(+), 25 deletions(-)

diff --git a/bashast/bashast.g b/bashast/bashast.g
index 610b495..fae2137 100644
--- a/bashast/bashast.g
+++ b/bashast/bashast.g
@@ -141,8 +141,10 @@ tokens{
 
 	C_INCLUDE #include "core/exceptions.h"
 }
+#endif
 @members
 {
+#ifdef OUTPUT_C
 	static std::string get_string(pANTLR3_COMMON_TOKEN token)
 	{
 		if(!token || !token->start)
@@ -166,10 +168,7 @@ tokens{
 	{
 		(&(scope->here_document_word))->std::string::~string();
 	}
-}
 #else
-@members
-{
 	boolean is_here_end(String here_document_word, int number_of_tokens) {
 		String word = "";
 		for(int i = 1; i <= number_of_tokens; ++i)
@@ -188,8 +187,37 @@ tokens{
 	int LA(int index) {
 		return input.LA(index);
 	}
-}
 #endif
+#ifdef OUTPUT_C
+	bool is_special_token(int token)
+#else
+	boolean is_special_token(int token)
+#endif
+	{
+		return token == AMP
+		||token == BLANK
+		// for bash redirection
+		||token == LESS_THAN
+		||token == GREATER_THAN
+		||token == RSHIFT
+		// for end of command
+		||token == SEMIC
+		||token == EOL
+		// for sub shell
+		||token == LPAREN
+		||token == RPAREN
+		// for case statement
+		||token == DOUBLE_SEMIC
+		// for logical operator
+		||token == LOGICAND
+		||token == LOGICOR
+		// for pipeline
+		||token == PIPE
+		// for document and here string
+		||token == HERE_STRING_OP
+		||token == LSHIFT;
+	}
+}
 
 start
 	:	((POUND) =>first_line_comment)? EOL* BLANK? command_list BLANK? (SEMIC|AMP|EOL)? EOF -> command_list;
@@ -326,28 +354,10 @@ command_atom
 			|	(
 					{LA(1) == BLANK &&
 					(
-						LA(2) != AMP
-						// Resolve conflicts with bash redirection
-						&&LA(2) != LESS_THAN
-						&&LA(2) != GREATER_THAN
-						&&LA(2) != RSHIFT
+						!is_special_token(LA(2))
+						// redirection
 						&&(LA(2) != DIGIT || (LA(3) != AMP && LA(3) != LESS_THAN
 											  && LA(3) != GREATER_THAN && LA(3) != RSHIFT))
-						// Resolve conflicts with end of command
-						&&LA(2) != SEMIC
-						&&LA(2) != EOL
-						// Resolve conflict with sub shell
-						&&LA(2) != RPAREN
-						// Resolve conflict with case statement
-						&&LA(2) != DOUBLE_SEMIC
-						// Resolve conflicts with logical operator
-						&&LA(2) != LOGICAND
-						&&LA(2) != LOGICOR
-						// Resolve conflict with pipeline
-						&&LA(2) != PIPE
-						// Resolve conflicts with here document and here string
-						&&LA(2) != HERE_STRING_OP
-						&&LA(2) != LSHIFT
 					)}? => BLANK bash_command_arguments
 				)* -> string_expr_no_reserved_word bash_command_arguments*
 		);
@@ -784,7 +794,7 @@ parameter_replace_pattern
 parameter_delete_pattern
 	:	parameter_pattern_part+ -> ^(STRING parameter_pattern_part+);
 parameter_pattern_part
-	:	extended_pattern_match|BLANK|SEMIC;
+	:	extended_pattern_match|{is_special_token(LA(1))}? => .;
 
 // TODO fix this rule
 parameter_expansion_value

diff --git a/bashast/gunit/param_main.gunit b/bashast/gunit/param_main.gunit
index 0a56a57..c83ccc2 100644
--- a/bashast/gunit/param_main.gunit
+++ b/bashast/gunit/param_main.gunit
@@ -47,6 +47,9 @@ variable_reference:
 "${foo%%bar}" -> (VAR_REF (REPLACE_AT_END foo (STRING bar)))
 "${foo%; *}" -> (VAR_REF (LAZY_REMOVE_AT_END foo (STRING ;   MATCH_ALL)))
 "${foo%/}" -> (VAR_REF (LAZY_REMOVE_AT_END foo (STRING /)))
+"${1%& <><<;
+();&&|<<<<<()*}" -> (VAR_REF (LAZY_REMOVE_AT_END 1 (STRING &   < > << ; 
+ ( ) ; && | <<< << ( ) MATCH_ALL)))
 "${this/is/pattern}"->(VAR_REF (REPLACE_FIRST this (STRING is) (STRING pattern)))
 //Test positional/special parameters
 "$1" -> (VAR_REF 1)



             reply	other threads:[~2011-08-04 13:56 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 13:53 Petteri Räty [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-19 14:35 [gentoo-commits] proj/libbash:master commit in: bashast/, bashast/gunit/ Petteri Räty
2012-06-03  9:08 Petteri Räty
2012-06-03  9:08 Petteri Räty
2012-06-03  9:08 Petteri Räty
2012-06-03  9:08 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-08-04 13:53 Petteri Räty
2011-07-20 13:08 Petteri Räty
2011-07-08 14:12 Petteri Räty
2011-06-21 13:26 Petteri Räty
2011-06-21 13:20 Petteri Räty
2011-06-21 13:20 Petteri Räty
2011-06-19 19:15 Petteri Räty
2011-06-15 21:18 Petteri Räty
2011-06-14  8:28 Petteri Räty
2011-06-14  8:28 Petteri Räty
2011-06-11  8:24 Petteri Räty
2011-06-11  8:24 Petteri Räty
2011-06-09 13:41 Petteri Räty
2011-06-09 13:41 Petteri Räty
2011-06-09  8:15 Petteri Räty
2011-06-01 12:03 Petteri Räty
2011-06-01 12:03 Petteri Räty
2011-06-01 12:03 Petteri Räty
2011-06-01 12:03 Petteri Räty
2011-06-01 12:03 Petteri Räty
2011-05-23 14:34 Petteri Räty
2011-05-22 21:00 Petteri Räty
2011-05-11  7:19 Petteri Räty
2011-05-11  7:19 Petteri Räty
2011-05-11  7:19 Petteri Räty
2011-05-07 12:25 Petteri Räty
2011-04-27 15:11 Petteri Räty
2011-04-20 11:26 Petteri Räty
2011-04-20 11:26 Petteri Räty
2011-04-20 11:26 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-17 10:58 Petteri Räty
2011-04-14  4:50 Petteri Räty
2011-04-14  4:50 Petteri Räty
2011-04-14  4:50 Petteri Räty
2011-04-12  7:19 Petteri Räty
2011-04-12  7:19 Petteri Räty
2011-04-12  7:19 Petteri Räty
2011-04-12  7:19 Petteri Räty
2011-04-11  6:50 Petteri Räty
2011-04-11  6:50 Petteri Räty
2011-04-11  6:50 Petteri Räty
2011-04-11  6:50 Petteri Räty
2011-04-11  5:21 Petteri Räty
2011-04-11  5:21 Petteri Räty
2011-04-11  5:21 Petteri Räty
2011-04-11  5:21 Petteri Räty
2011-04-09  6:27 Petteri Räty
2011-04-09  6:27 Petteri Räty
2011-04-09  6:27 Petteri Räty
2011-04-09  6:27 Petteri Räty
2011-04-08 14:26 Petteri Räty
2011-04-07 16:45 Petteri Räty
2011-04-07  7:48 Petteri Räty
2011-04-06  7:43 Petteri Räty
2011-03-30 12:48 Petteri Räty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4241b112b64937a27b4ff04917fe6f497e98c123.betelgeuse@gentoo \
    --to=betelgeuse@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox