public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Alexandre Restovtsev" <tetromino@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gnome:gnome-next commit in: media-sound/sound-juicer/, media-sound/sound-juicer/files/
Date: Sat,  6 Aug 2011 07:33:49 +0000 (UTC)	[thread overview]
Message-ID: <35b4071b20d8234f7f6b8a3d0fe61929ab41f635.tetromino@gentoo> (raw)

commit:     35b4071b20d8234f7f6b8a3d0fe61929ab41f635
Author:     Alexandre Rostovtsev <tetromino <AT> gmail <DOT> com>
AuthorDate: Sat Aug  6 07:29:14 2011 +0000
Commit:     Alexandre Restovtsev <tetromino <AT> gmail <DOT> com>
CommitDate: Sat Aug  6 07:32:23 2011 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commit;h=35b4071b

media-sound/sound-juicer: fix .desktop file (#377855)

Add a tiny patch to use a non-generic Name field in sound-juicer's
.desktop file; addresses Gentoo bug #377855 and satisfies Gnome policy
(see https://live.gnome.org/GnomeGoals/CorrectDesktopFiles).

Upstream bug is at https://bugzilla.gnome.org/show_bug.cgi?id=616860

No revision bump since this is a trivial change.

---
 .../files/sound-juicer-correct-desktop-files.patch |   13 +++++++++++++
 .../sound-juicer-2.99.0_pre20110405.ebuild         |    6 +++++-
 2 files changed, 18 insertions(+), 1 deletions(-)

diff --git a/media-sound/sound-juicer/files/sound-juicer-correct-desktop-files.patch b/media-sound/sound-juicer/files/sound-juicer-correct-desktop-files.patch
new file mode 100644
index 0000000..5d7546b
--- /dev/null
+++ b/media-sound/sound-juicer/files/sound-juicer-correct-desktop-files.patch
@@ -0,0 +1,13 @@
+diff --git a/data/sound-juicer.desktop.in.in b/data/sound-juicer.desktop.in.in
+index ecd42e0..3a7dc28 100644
+--- a/data/sound-juicer.desktop.in.in
++++ b/data/sound-juicer.desktop.in.in
+@@ -1,5 +1,7 @@
+ [Desktop Entry]
+-_Name=Audio CD Extractor
++_Name=Sound Juicer
++_GenericName=Audio CD Extractor
++_X-GNOME-FullName=Sound Juicer Audio CD Extractor
+ _Comment=Copy music from your CDs
+ Exec=sound-juicer %u
+ Icon=sound-juicer

diff --git a/media-sound/sound-juicer/sound-juicer-2.99.0_pre20110405.ebuild b/media-sound/sound-juicer/sound-juicer-2.99.0_pre20110405.ebuild
index bf178c0..8fd3b5c 100644
--- a/media-sound/sound-juicer/sound-juicer-2.99.0_pre20110405.ebuild
+++ b/media-sound/sound-juicer/sound-juicer-2.99.0_pre20110405.ebuild
@@ -6,7 +6,7 @@ EAPI="4"
 GCONF_DEBUG="yes"
 GNOME2_LA_PUNT="yes"
 
-inherit autotools gnome2
+inherit autotools eutils gnome2
 if [[ ${PV} = 9999 ]]; then
 	inherit gnome2-live
 fi
@@ -63,6 +63,10 @@ pkg_setup() {
 }
 
 src_prepare() {
+	# Use non-generic application name. See bug #377855, upstream bug 616860,
+	# and https://live.gnome.org/GnomeGoals/CorrectDesktopFiles
+	epatch "${FILESDIR}/${PN}-correct-desktop-files.patch"
+
 	gnome-doc-common
 	gnome-doc-prepare --automake
 	intltoolize --force



                 reply	other threads:[~2011-08-06  7:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35b4071b20d8234f7f6b8a3d0fe61929ab41f635.tetromino@gentoo \
    --to=tetromino@gmail.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox