From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:2.1.9 commit in: pym/repoman/
Date: Tue, 1 Mar 2011 20:55:25 +0000 (UTC) [thread overview]
Message-ID: <33b6ee0f8e60d4940f270a06de48bd5bbee45a0d.zmedico@gentoo> (raw)
commit: 33b6ee0f8e60d4940f270a06de48bd5bbee45a0d
Author: Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Mon Feb 28 20:37:22 2011 +0000
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Tue Mar 1 20:53:42 2011 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=33b6ee0f
repoman: variable.usedwithhelpers ignore quoted
---
pym/repoman/checks.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 566984a..200b542 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -333,7 +333,9 @@ class NoOffsetWithHelpers(LineCheck):
helpers """
repoman_check_name = 'variable.usedwithhelpers'
- re = re.compile(r'^[^#]*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
+ # Ignore matches in quoted strings like this:
+ # elog "installed into ${ROOT}usr/share/php5/apc/."
+ re = re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
error = errors.NO_OFFSET_WITH_HELPERS
class ImplicitRuntimeDeps(LineCheck):
next reply other threads:[~2011-03-01 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 20:55 Zac Medico [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-04 20:03 [gentoo-commits] proj/portage:2.1.9 commit in: pym/repoman/ Zac Medico
2011-03-01 20:55 Zac Medico
2011-02-20 0:04 Zac Medico
2011-02-14 4:31 Zac Medico
2011-02-05 0:59 Zac Medico
2011-02-04 6:07 zmedico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b6ee0f8e60d4940f270a06de48bd5bbee45a0d.zmedico@gentoo \
--to=zmedico@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox