public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Matt Turner" <mattst88@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/catalyst:master commit in: catalyst/targets/
Date: Sat, 24 Oct 2020 22:07:49 +0000 (UTC)	[thread overview]
Message-ID: <1603427388.6a4fa88d18afefc4aac328dd5bf60d2a13026f2e.mattst88@gentoo> (raw)
Message-ID: <20201024220749.uo4KCwDMDRWCPajbBxUl68wY0lz7fORTNGGoGmUAPlk@z> (raw)

commit:     6a4fa88d18afefc4aac328dd5bf60d2a13026f2e
Author:     Matt Turner <mattst88 <AT> gentoo <DOT> org>
AuthorDate: Fri Oct 23 04:28:48 2020 +0000
Commit:     Matt Turner <mattst88 <AT> gentoo <DOT> org>
CommitDate: Fri Oct 23 04:29:48 2020 +0000
URL:        https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=6a4fa88d

catalyst: Explicitly keep /etc/resolv.conf in stage4

It was confusing to understand that /etc/resolv.conf was *kept* in
stage4 because its set_cleanables() contained everything except it.

This will simplify things if we want to add more common items to the
cleanables list.

Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>

 catalyst/targets/stage4.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/catalyst/targets/stage4.py b/catalyst/targets/stage4.py
index a9b3c936..346c0845 100644
--- a/catalyst/targets/stage4.py
+++ b/catalyst/targets/stage4.py
@@ -32,7 +32,11 @@ class stage4(StageBase):
         StageBase.__init__(self, spec, addlargs)
 
     def set_cleanables(self):
-        self.settings["cleanables"] = ["/var/tmp/*", "/tmp/*"]
+        StageBase.set_cleanables(self)
+
+        # We want to allow stage4's fsscript to generate a default
+        # /etc/resolv.conf
+        self.settings["cleanables"].remove('/etc/resolv.conf')
 
     def set_action_sequence(self):
         self.settings['action_sequence'] = [


             reply	other threads:[~2020-10-24 22:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 21:00 Matt Turner [this message]
2020-10-23  4:36 ` [gentoo-commits] proj/catalyst:pending/mattst88 commit in: catalyst/targets/ Matt Turner
2020-10-24 22:07 ` [gentoo-commits] proj/catalyst:master " Matt Turner
  -- strict thread matches above, loose matches on Subject: below --
2022-11-20  0:21 [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2021-02-21  2:05 [gentoo-commits] proj/catalyst:master " Matt Turner
2021-06-10  0:48 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2021-01-18 19:53 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-12-19 19:56 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-24 22:07 [gentoo-commits] proj/catalyst:master " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-23  4:36 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-05-20  3:39 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-05-19 22:55 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603427388.6a4fa88d18afefc4aac328dd5bf60d2a13026f2e.mattst88@gentoo \
    --to=mattst88@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox