public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] proj/portage:repoman commit in: repoman/pym/repoman/modules/linechecks/portage/
@ 2018-03-30  5:20 Zac Medico
  2018-03-30  4:23 ` [gentoo-commits] proj/portage:master " Zac Medico
  0 siblings, 1 reply; 2+ messages in thread
From: Zac Medico @ 2018-03-30  5:20 UTC (permalink / raw
  To: gentoo-commits

commit:     3ea468dde4de8ec14c9da1dd6d522a31cc443851
Author:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Sat Jul 15 01:04:00 2017 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Fri Mar 30 03:51:18 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=3ea468dd

repoman: New linechecks module, portage

 .../repoman/modules/linechecks/portage/__init__.py | 27 ++++++++++++++++
 .../repoman/modules/linechecks/portage/internal.py | 37 ++++++++++++++++++++++
 2 files changed, 64 insertions(+)

diff --git a/repoman/pym/repoman/modules/linechecks/portage/__init__.py b/repoman/pym/repoman/modules/linechecks/portage/__init__.py
new file mode 100644
index 000000000..d390c6054
--- /dev/null
+++ b/repoman/pym/repoman/modules/linechecks/portage/__init__.py
@@ -0,0 +1,27 @@
+# Copyright 2015-2016 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+
+doc = """Portage plug-in module for repoman LineChecks.
+Performs checks for internal portage variable usage in ebuilds."""
+__doc__ = doc[:]
+
+
+module_spec = {
+	'name': 'do',
+	'description': doc,
+	'provides':{
+		'internal-check': {
+			'name': "portageinternal",
+			'sourcefile': "internal",
+			'class': "PortageInternal",
+			'description': doc,
+		},
+		'portageinternalvariableassignment-check': {
+			'name': "portageinternalvariableassignment",
+			'sourcefile': "internal",
+			'class': "PortageInternalVariableAssignment",
+			'description': doc,
+		},
+	}
+}
+

diff --git a/repoman/pym/repoman/modules/linechecks/portage/internal.py b/repoman/pym/repoman/modules/linechecks/portage/internal.py
new file mode 100644
index 000000000..869337221
--- /dev/null
+++ b/repoman/pym/repoman/modules/linechecks/portage/internal.py
@@ -0,0 +1,37 @@
+
+import re
+
+from repoman.modules.linechecks.base import LineCheck
+
+
+class PortageInternal(LineCheck):
+	repoman_check_name = 'portage.internal'
+	ignore_comment = True
+	# Match when the command is preceded only by leading whitespace or a shell
+	# operator such as (, {, |, ||, or &&. This prevents false positives in
+	# things like elog messages, as reported in bug #413285.
+
+	internal_portage_func_or_var = (
+		'ecompress|ecompressdir|env-update|prepall|prepalldocs|preplib')
+	re = re.compile(
+		r'^(\s*|.*[|&{(]+\s*)\b(%s)\b' % internal_portage_func_or_var)
+
+	def check(self, num, line):
+		"""Run the check on line and return error if there is one"""
+		m = self.re.match(line)
+		if m is not None:
+			return ("'%s'" % m.group(2)) + " called on line: %d"
+
+
+class PortageInternalVariableAssignment(LineCheck):
+	repoman_check_name = 'portage.internal'
+	internal_assignment = re.compile(
+		r'\s*(export\s+)?(EXTRA_ECONF|EXTRA_EMAKE)\+?=')
+
+	def check(self, num, line):
+		match = self.internal_assignment.match(line)
+		e = None
+		if match is not None:
+			e = 'Assignment to variable %s' % match.group(2)
+			e += ' on line: %d'
+		return e


^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-30  5:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-30  5:20 [gentoo-commits] proj/portage:repoman commit in: repoman/pym/repoman/modules/linechecks/portage/ Zac Medico
2018-03-30  4:23 ` [gentoo-commits] proj/portage:master " Zac Medico

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox