[gentoo-commits] gentoo-x86 commit in net-nntp/nzbget/files: nzbget.initd nzbget-9.0_pre477-buffer-overflows.patch nzbget-9.0_pre477-header.patch

[gentoo-commits] gentoo-x86 commit in net-nntp/nzbget/files: nzbget.initd nzbget-9.0_pre477-buffer-overflows.patch nzbget-9.0_pre477-header.patch

[Tim Harder (radhermit)]

radhermit    12/11/02 06:15:58

  Modified:             nzbget.initd
  Added:                nzbget-9.0_pre477-buffer-overflows.patch
                        nzbget-9.0_pre477-header.patch
  Log:
  Version bump to development release. Fix potential buffer overflows (bug #434264), change from /var/run to /run, remove need
  
  (Portage version: 2.2.0_alpha141/cvs/Linux x86_64, signed Manifest commit with key 4AB3E85B4F064CA3)

Revision  Changes    Path
1.4                  net-nntp/nzbget/files/nzbget.initd

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget.initd?rev=1.4&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget.initd?rev=1.4&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget.initd?r1=1.3&r2=1.4

Index: nzbget.initd
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-nntp/nzbget/files/nzbget.initd,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- nzbget.initd	25 Dec 2011 07:42:35 -0000	1.3
+++ nzbget.initd	2 Nov 2012 06:15:57 -0000	1.4
@@ -1,14 +1,10 @@
 #!/sbin/runscript
-# Copyright 1999-2011 Gentoo Foundation
+# Copyright 1999-2012 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-nntp/nzbget/files/nzbget.initd,v 1.3 2011/12/25 07:42:35 radhermit Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-nntp/nzbget/files/nzbget.initd,v 1.4 2012/11/02 06:15:57 radhermit Exp $
 
 extra_started_commands="pause unpause"
 
-depend() {
-	need net
-}
-
 start() {
 	ebegin "Starting nzbget"
 	start-stop-daemon --quiet --start --user "${NZBGET_USER}" \



1.1                  net-nntp/nzbget/files/nzbget-9.0_pre477-buffer-overflows.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget-9.0_pre477-buffer-overflows.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget-9.0_pre477-buffer-overflows.patch?rev=1.1&content-type=text/plain

Index: nzbget-9.0_pre477-buffer-overflows.patch
===================================================================
--- nzbget-9.0-testing/RemoteClient.cpp
+++ nzbget-9.0-testing/RemoteClient.cpp
@@ -541,20 +541,20 @@
 				{
 					if (szParameters[0] == '\0')
 					{
-						strncat(szParameters, " (", 1024);
+						strncat(szParameters, " (", sizeof(szParameters) - strlen(szParameters) - 1);
 					}
 					else
 					{
-						strncat(szParameters, ", ", 1024);
+						strncat(szParameters, ", ", sizeof(szParameters) - strlen(szParameters) - 1);
 					}
 					NZBParameter* pNZBParameter = *it;
-					strncat(szParameters, pNZBParameter->GetName(), 1024);
-					strncat(szParameters, "=", 1024);
-					strncat(szParameters, pNZBParameter->GetValue(), 1024);
+					strncat(szParameters, pNZBParameter->GetName(), sizeof(szParameters) - strlen(szParameters) - 1);
+					strncat(szParameters, "=", sizeof(szParameters) - strlen(szParameters) - 1);
+					strncat(szParameters, pNZBParameter->GetValue(), sizeof(szParameters) - strlen(szParameters) - 1);
 				}
 				if (szParameters[0] != '\0')
 				{
-					strncat(szParameters, ")", 1024);
+					strncat(szParameters, ")", sizeof(szParameters) - strlen(szParameters) - 1);
 				}
 
 				if (!szPattern || ((MatchedNZBInfo*)pGroupInfo->GetNZBInfo())->m_bMatch)
@@ -672,10 +672,10 @@
 
 	if (ntohl(ListResponse.m_iPostJobCount) > 0 || ntohl(ListResponse.m_bPostPaused))
 	{
-		strncat(szServerState, strlen(szServerState) > 0 ? ", Post-Processing" : "Post-Processing", sizeof(szServerState));
+		strncat(szServerState, strlen(szServerState) > 0 ? ", Post-Processing" : "Post-Processing", sizeof(szServerState) - strlen(szServerState) - 1);
 		if (ntohl(ListResponse.m_bPostPaused))
 		{
-			strncat(szServerState, " paused", sizeof(szServerState));
+			strncat(szServerState, " paused", sizeof(szServerState) - strlen(szServerState) - 1);
 		}
 	}
 



1.1                  net-nntp/nzbget/files/nzbget-9.0_pre477-header.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget-9.0_pre477-header.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-nntp/nzbget/files/nzbget-9.0_pre477-header.patch?rev=1.1&content-type=text/plain

Index: nzbget-9.0_pre477-header.patch
===================================================================
--- nzbget-9.0-testing/Scanner.cpp
+++ nzbget-9.0-testing/Scanner.cpp
@@ -36,6 +36,8 @@
 #include <fstream>
 #ifdef WIN32
 #include <direct.h>
+#else
+#include <unistd.h>
 #endif
 #include <sys/stat.h>
 #include <errno.h>