[gentoo-commits] gentoo-x86 commit in x11-libs/gtk+/files: gtk+-2.24.11-stuck-grab.patch

[gentoo-commits] gentoo-x86 commit in x11-libs/gtk+/files: gtk+-2.24.11-stuck-grab.patch

[Alexandre Rostovtsev (tetromino)]

tetromino    12/07/20 23:58:12

  Added:                gtk+-2.24.11-stuck-grab.patch
  Log:
  Fix stuck keyboard grab in pidgin and gajim (bug #427148, thanks to Christian Trefzer, Rafał Mużyło, shinydoofy).
  
  (Portage version: 2.2.0_alpha120/cvs/Linux x86_64)

Revision  Changes    Path
1.1                  x11-libs/gtk+/files/gtk+-2.24.11-stuck-grab.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-libs/gtk+/files/gtk+-2.24.11-stuck-grab.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-libs/gtk+/files/gtk+-2.24.11-stuck-grab.patch?rev=1.1&content-type=text/plain

Index: gtk+-2.24.11-stuck-grab.patch
===================================================================
From f3afba6202a442d1c3381b2c0fe314814b73168b Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Wed, 16 May 2012 17:18:51 -0400
Subject: [PATCH] Fix a case of 'stuck grab'

This was showing up when using a combo box in list mode. After popping
up the list, the keyboard grab appeared stuck. What was stuck here is
only the client-side grab, since we forgot to clean up our grabs
when receiving an UnmapNotify.

This bug was introduced in 3f6592f60fd15fb353fc84600caefba3054dc892.

[ Alexandre Rostovtsev <tetromino@gentoo.org>: backport to 2.24 ]

https://bugzilla.gnome.org/show_bug.cgi?id=680346
---
 gdk/x11/gdkevents-x11.c |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/gdk/x11/gdkevents-x11.c b/gdk/x11/gdkevents-x11.c
index 7cc1000..b96e9f5 100644
--- a/gdk/x11/gdkevents-x11.c
+++ b/gdk/x11/gdkevents-x11.c
@@ -1799,16 +1799,15 @@ gdk_event_translate (GdkDisplay *display,
            * means we hid the window ourselves, so we will have already flipped
            * the iconified bit off.
            */
-          if (window)
-            {
-              if (GDK_WINDOW_IS_MAPPED (window))
-                gdk_synthesize_window_state (window,
-                                             0,
-                                             GDK_WINDOW_STATE_ICONIFIED);
-
-              _gdk_xgrab_check_unmap (window, xevent->xany.serial);
-            }
+          if (window && GDK_WINDOW_IS_MAPPED (window))
+            gdk_synthesize_window_state (window,
+                                         0,
+                                         GDK_WINDOW_STATE_ICONIFIED);
         }
+
+      if (window)
+        _gdk_xgrab_check_unmap (window, xevent->xany.serial);
+
       break;
       
     case MapNotify:
-- 
1.7.8.6