public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michal Gorny (mgorny)" <mgorny@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] gentoo-x86 commit in eclass: systemd.eclass
Date: Thu, 16 Jun 2011 16:39:18 +0000 (UTC)	[thread overview]
Message-ID: <20110616163918.4AAC720054@flycatcher.gentoo.org> (raw)

mgorny      11/06/16 16:39:18

  Modified:             systemd.eclass
  Log:
  Support passing an optional configure option name to systemd_with_unitdir.

Revision  Changes    Path
1.4                  eclass/systemd.eclass

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/systemd.eclass?rev=1.4&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/systemd.eclass?rev=1.4&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/systemd.eclass?r1=1.3&r2=1.4

Index: systemd.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/systemd.eclass,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- systemd.eclass	11 Jun 2011 06:06:43 -0000	1.3
+++ systemd.eclass	16 Jun 2011 16:39:18 -0000	1.4
@@ -1,6 +1,6 @@
 # Copyright 1999-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/systemd.eclass,v 1.3 2011/06/11 06:06:43 mgorny Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/systemd.eclass,v 1.4 2011/06/16 16:39:18 mgorny Exp $
 
 # @ECLASS: systemd.eclass
 # @MAINTAINER:
@@ -88,15 +88,22 @@
 }
 
 # @FUNCTION: systemd_with_unitdir
+# @USAGE: [configure option]
 # @DESCRIPTION:
 # Output '--with-systemdsystemunitdir' as expected by systemd-aware configure
 # scripts. This function always succeeds. Its output may be quoted in order
 # to preserve whitespace in paths. systemd_to_myeconfargs() is preferred over
 # this function.
+#
+# If upstream does use invalid configure option to handle installing systemd
+# units (e.g. `--with-systemdunitdir'), you can pass the 'suffix' as an optional
+# argument to this function (`$(systemd_with_unitdir systemdunitdir)'). Please
+# remember to report a bug upstream as well.
 systemd_with_unitdir() {
 	debug-print-function ${FUNCNAME} "${@}"
+	local optname=${1:-systemdsystemunitdir}
 
-	echo -n --with-systemdsystemunitdir="$(systemd_get_unitdir)"
+	echo -n --with-${optname}="$(systemd_get_unitdir)"
 }
 
 # @FUNCTION: systemd_to_myeconfargs






             reply	other threads:[~2011-06-16 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 16:39 Michal Gorny (mgorny) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-04-13 22:36 [gentoo-commits] gentoo-x86 commit in eclass: systemd.eclass Michal Gorny (mgorny)
2011-09-17 13:48 Michal Gorny (mgorny)
2011-07-28 13:47 Zac Medico (zmedico)
2011-06-24 13:13 Jeremy Olexa (darkside)
2011-06-19 16:05 Michal Gorny (mgorny)
2011-06-11  6:06 Michal Gorny (mgorny)
2011-05-04 16:02 Michal Gorny (mgorny)
2011-05-04 10:53 Michal Gorny (mgorny)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110616163918.4AAC720054@flycatcher.gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox