public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] gentoo-x86 commit in media-sound/amarok/files: amarok-2.3.2-flac-fix.patch
@ 2010-09-19  5:10 Jorge Manuel B. S. Vicetto (jmbsvicetto)
  0 siblings, 0 replies; only message in thread
From: Jorge Manuel B. S. Vicetto (jmbsvicetto) @ 2010-09-19  5:10 UTC (permalink / raw
  To: gentoo-commits

jmbsvicetto    10/09/19 05:10:25

  Added:                amarok-2.3.2-flac-fix.patch
  Log:
  [media-sound/amarok-2.3.2] Bumped amarok to the 2.3.2 release - masked until the public release.
  Applied commit ce57e426 from the git tree to fix a BMP tag bug related to flac files - thanks to Jeff Mitchell <mitchell AT kde DOT org>.
  
  (Portage version: 2.2_rc83/cvs/Linux x86_64)

Revision  Changes    Path
1.1                  media-sound/amarok/files/amarok-2.3.2-flac-fix.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/amarok/files/amarok-2.3.2-flac-fix.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/amarok/files/amarok-2.3.2-flac-fix.patch?rev=1.1&content-type=text/plain

Index: amarok-2.3.2-flac-fix.patch
===================================================================
commit ce57e4264d0395b15e7253e3cdef48e36a8b129c
Author: Jeff Mitchell <mitchell@kde.org>
Date:   Fri Sep 17 13:02:38 2010 -0400

    FLAC BPM tags could be read in incorrectly.
    
    BUG: 234166

diff --git a/utilities/collectionscanner/CollectionScanner.cpp b/utilities/collectionscanner/CollectionScanner.cpp
index a9d6755..0a23a53 100644
--- a/utilities/collectionscanner/CollectionScanner.cpp
+++ b/utilities/collectionscanner/CollectionScanner.cpp
@@ -701,7 +701,7 @@ CollectionScanner::readTags( const QString &path, TagLib::AudioProperties::ReadS
                     attributes["composer"] = TStringToQString( file->xiphComment()->fieldListMap()["COMPOSER"].front() ).trimmed();
 
                 if ( !file->xiphComment()->fieldListMap()[ "BPM" ].isEmpty() )
-                    attributes["bpm"] = TStringToQString( file->xiphComment()->fieldListMap()["BPM"].front() ).trimmed().toFloat();
+                    attributes["bpm"] = TStringToQString( file->xiphComment()->fieldListMap()["BPM"].front() ).trimmed();
 
                 if ( !file->xiphComment()->fieldListMap()[ "DISCNUMBER" ].isEmpty() )
                     disc = TStringToQString( file->xiphComment()->fieldListMap()["DISCNUMBER"].front() ).trimmed();





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-09-19  5:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-19  5:10 [gentoo-commits] gentoo-x86 commit in media-sound/amarok/files: amarok-2.3.2-flac-fix.patch Jorge Manuel B. S. Vicetto (jmbsvicetto)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox