From: "Jorge Manuel B. S. Vicetto (jmbsvicetto)" <jmbsvicetto@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] gentoo-x86 commit in media-sound/amarok/files: amarok-2.3.2-flac-fix.patch
Date: Sun, 19 Sep 2010 05:10:25 +0000 (UTC) [thread overview]
Message-ID: <20100919051025.6538B20054@flycatcher.gentoo.org> (raw)
jmbsvicetto 10/09/19 05:10:25
Added: amarok-2.3.2-flac-fix.patch
Log:
[media-sound/amarok-2.3.2] Bumped amarok to the 2.3.2 release - masked until the public release.
Applied commit ce57e426 from the git tree to fix a BMP tag bug related to flac files - thanks to Jeff Mitchell <mitchell AT kde DOT org>.
(Portage version: 2.2_rc83/cvs/Linux x86_64)
Revision Changes Path
1.1 media-sound/amarok/files/amarok-2.3.2-flac-fix.patch
file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/amarok/files/amarok-2.3.2-flac-fix.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/amarok/files/amarok-2.3.2-flac-fix.patch?rev=1.1&content-type=text/plain
Index: amarok-2.3.2-flac-fix.patch
===================================================================
commit ce57e4264d0395b15e7253e3cdef48e36a8b129c
Author: Jeff Mitchell <mitchell@kde.org>
Date: Fri Sep 17 13:02:38 2010 -0400
FLAC BPM tags could be read in incorrectly.
BUG: 234166
diff --git a/utilities/collectionscanner/CollectionScanner.cpp b/utilities/collectionscanner/CollectionScanner.cpp
index a9d6755..0a23a53 100644
--- a/utilities/collectionscanner/CollectionScanner.cpp
+++ b/utilities/collectionscanner/CollectionScanner.cpp
@@ -701,7 +701,7 @@ CollectionScanner::readTags( const QString &path, TagLib::AudioProperties::ReadS
attributes["composer"] = TStringToQString( file->xiphComment()->fieldListMap()["COMPOSER"].front() ).trimmed();
if ( !file->xiphComment()->fieldListMap()[ "BPM" ].isEmpty() )
- attributes["bpm"] = TStringToQString( file->xiphComment()->fieldListMap()["BPM"].front() ).trimmed().toFloat();
+ attributes["bpm"] = TStringToQString( file->xiphComment()->fieldListMap()["BPM"].front() ).trimmed();
if ( !file->xiphComment()->fieldListMap()[ "DISCNUMBER" ].isEmpty() )
disc = TStringToQString( file->xiphComment()->fieldListMap()["DISCNUMBER"].front() ).trimmed();
reply other threads:[~2010-09-19 5:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100919051025.6538B20054@flycatcher.gentoo.org \
--to=jmbsvicetto@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox