* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2009-08-18 6:26 Robin H. Johnson (robbat2)
0 siblings, 0 replies; 10+ messages in thread
From: Robin H. Johnson (robbat2) @ 2009-08-18 6:26 UTC (permalink / raw
To: gentoo-commits
robbat2 09/08/18 06:26:04
Modified: usercp_register.php
Log:
Get rid of an evil manually-built massive where clause and replace with a nice left outer join to find stale entries.
Revision Changes Path
1.29 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.29&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.29&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.28&r2=1.29
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.28
retrieving revision 1.29
diff -p -w -b -B -u -u -r1.28 -r1.29
--- usercp_register.php 30 Jul 2009 06:38:50 -0000 1.28
+++ usercp_register.php 18 Aug 2009 06:26:04 -0000 1.29
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.28 2009/07/30 06:38:50 desultory Exp $
+ * $Id: usercp_register.php,v 1.29 2009/08/18 06:26:04 robbat2 Exp $
*
*
***************************************************************************/
@@ -1282,15 +1282,22 @@ else
if ($row = $db->sql_fetchrow($result))
{
- $confirm_sql = '';
- do
- {
- $confirm_sql .= (($confirm_sql != '') ? ', ' : '') . "'" . $row['session_id'] . "'";
- }
- while ($row = $db->sql_fetchrow($result));
+ // 2009-08-17 robbat2 - JOINs are good for your health
+ // Old:
+ //$confirm_sql = '';
+ //do
+ //{
+ // $confirm_sql .= (($confirm_sql != '') ? ', ' : '') . "'" . $row['session_id'] . "'";
+ //}
+ //while ($row = $db->sql_fetchrow($result));
+ //
+ //$sql = 'DELETE FROM ' . CONFIRM_TABLE . "
+ // WHERE session_id NOT IN ($confirm_sql)";
+ // New:
+ $sql = 'DELETE c FROM ' . CONFIRM_TABLE . ' c
+ LEFT JOIN phpbb_sessions se USING (session_id)
+ WHERE se.session_id IS NULL;';
- $sql = 'DELETE FROM ' . CONFIRM_TABLE . "
- WHERE session_id NOT IN ($confirm_sql)";
if (!$db->sql_query($sql))
{
message_die(GENERAL_ERROR, 'Could not delete stale confirm data', '', __LINE__, __FILE__, $sql);
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2009-08-19 18:00 Robin H. Johnson (robbat2)
0 siblings, 0 replies; 10+ messages in thread
From: Robin H. Johnson (robbat2) @ 2009-08-19 18:00 UTC (permalink / raw
To: gentoo-commits
robbat2 09/08/19 18:00:44
Modified: usercp_register.php
Log:
Use auto_increment keys for phpbb_users.user_id. Remember to alter the table to be auto_increment before using this!.
Revision Changes Path
1.30 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.30&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.30&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.29&r2=1.30
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.29
retrieving revision 1.30
diff -p -w -b -B -u -u -r1.29 -r1.30
--- usercp_register.php 18 Aug 2009 06:26:04 -0000 1.29
+++ usercp_register.php 19 Aug 2009 18:00:44 -0000 1.30
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.29 2009/08/18 06:26:04 robbat2 Exp $
+ * $Id: usercp_register.php,v 1.30 2009/08/19 18:00:44 robbat2 Exp $
*
*
***************************************************************************/
@@ -800,18 +800,19 @@ if ( isset($HTTP_POST_VARS['submit']) )
}
- $sql = "SELECT MAX(user_id) AS total
- FROM " . USERS_TABLE;
- if ( !($result = $db->sql_query($sql)) )
- {
- message_die(GENERAL_ERROR, 'Could not obtain next user_id information', '', __LINE__, __FILE__, $sql);
- }
+ // 2009-08-19 robbat2 - disabled to allow safe auto_increment instead
+ // $sql = "SELECT MAX(user_id) AS total
+ // FROM " . USERS_TABLE;
+ // if ( !($result = $db->sql_query($sql)) )
+ // {
+ // message_die(GENERAL_ERROR, 'Could not obtain next user_id information', '', __LINE__, __FILE__, $sql);
+ // }
- if ( !($row = $db->sql_fetchrow($result)) )
- {
- message_die(GENERAL_ERROR, 'Could not obtain next user_id information', '', __LINE__, __FILE__, $sql);
- }
- $user_id = $row['total'] + 1;
+ // if ( !($row = $db->sql_fetchrow($result)) )
+ // {
+ // message_die(GENERAL_ERROR, 'Could not obtain next user_id information', '', __LINE__, __FILE__, $sql);
+ // }
+ // $user_id = $row['total'] + 1;
// 2006-02-02 tomk - store coppa details
$user_require_activation = ( $coppa ) ? USER_ACTIVATION_COPPA : $board_config['require_activation'];
@@ -821,8 +822,9 @@ if ( isset($HTTP_POST_VARS['submit']) )
//
// 2005-06-28 tomk - jabber diff++
// 2005-09-07 ian! - adding user_showavatars
- $sql = "INSERT INTO " . USERS_TABLE . " (user_id, username, user_regdate, user_password, user_email, user_icq, user_website, user_occ, user_from, user_interests, user_sig, user_sig_bbcode_uid, user_avatar, user_avatar_type, user_viewemail, user_aim, user_yim, user_msnm, user_jabber, user_attachsig, user_allowsmile, user_allowhtml, user_allowbbcode, user_allow_viewonline, user_notify, user_notify_pm, user_popup_pm, user_timezone, user_dateformat, user_lang, user_style, user_level, user_allow_pm, user_active, user_actkey, user_showavatars, user_reg_ip, user_require_activation, user_author_view)
- VALUES ($user_id, '" . str_replace("\'", "''", $username) . "', " . time() . ", '" . str_replace("\'", "''", $new_password) . "', '" . str_replace("\'", "''", $email) . "', '" . str_replace("\'", "''", $icq) . "', '" . str_replace("\'", "''", $website) . "', '" . str_replace("\'", "''", $occupation) . "', '" . str_replace("\'", "''", $location) . "', '" . str_replace("\'", "''", $interests) . "', '" . str_replace("\'", "''", $signature) . "', '$signature_bbcode_uid', $avatar_sql, $viewemail, '" . str_replace("\'", "''", str_replace(' ', '+', $aim)) . "', '" . str_replace("\'", "''", $yim) . "', '" . str_replace("\'", "''", $msn) . "', '" . str_replace("\'", "''", $jabber) . "', $attachsig, $allowsmilies, $allowhtml, $allowbbcode, $allowviewonline, $notifyreply, $notifypm, $popup_pm, $user_timezone, '" . str_replace("\'", "''", $user_dateformat) . "', '" . str_replace("\'", "''", $user_lang) . "', $user_style, 0, 1, ";
+ // 2009-08-19 robbat2 - user_id NOT explicitly set, but returned instead
+ $sql = "INSERT INTO " . USERS_TABLE . " (username, user_regdate, user_password, user_email, user_icq, user_website, user_occ, user_from, user_interests, user_sig, user_sig_bbcode_uid, user_avatar, user_avatar_type, user_viewemail, user_aim, user_yim, user_msnm, user_jabber, user_attachsig, user_allowsmile, user_allowhtml, user_allowbbcode, user_allow_viewonline, user_notify, user_notify_pm, user_popup_pm, user_timezone, user_dateformat, user_lang, user_style, user_level, user_allow_pm, user_active, user_actkey, user_showavatars, user_reg_ip, user_require_activation, user_author_view)
+ VALUES ('" . str_replace("\'", "''", $username) . "', " . time() . ", '" . str_replace("\'", "''", $new_password) . "', '" . str_replace("\'", "''", $email) . "', '" . str_replace("\'", "''", $icq) . "', '" . str_replace("\'", "''", $website) . "', '" . str_replace("\'", "''", $occupation) . "', '" . str_replace("\'", "''", $location) . "', '" . str_replace("\'", "''", $interests) . "', '" . str_replace("\'", "''", $signature) . "', '$signature_bbcode_uid', $avatar_sql, $viewemail, '" . str_replace("\'", "''", str_replace(' ', '+', $aim)) . "', '" . str_replace("\'", "''", $yim) . "', '" . str_replace("\'", "''", $msn) . "', '" . str_replace("\'", "''", $jabber) . "', $attachsig, $allowsmilies, $allowhtml, $allowbbcode, $allowviewonline, $notifyreply, $notifypm, $popup_pm, $user_timezone, '" . str_replace("\'", "''", $user_dateformat) . "', '" . str_replace("\'", "''", $user_lang) . "', $user_style, 0, 1, ";
if ( $board_config['require_activation'] == USER_ACTIVATION_SELF || $board_config['require_activation'] == USER_ACTIVATION_ADMIN || $coppa || $board_config['require_activation'] == USER_ACTIVATION_WATCHED_IP || $board_config['require_activation'] == USER_ACTIVATION_MULTI_IP )
{
// 2006-02-07 tomk - use a longer, variable length key with higher entropy to prevent key guessing
@@ -842,6 +844,9 @@ if ( isset($HTTP_POST_VARS['submit']) )
message_die(GENERAL_ERROR, 'Could not insert data into users table', '', __LINE__, __FILE__, $sql);
}
+ // 2009-08-19 robbat2 - now we can get the user_id that was just created.
+ $user_id = $db->sql_nextid();
+
$sql = "INSERT INTO " . GROUPS_TABLE . " (group_name, group_description, group_single_user, group_moderator)
VALUES ('', 'Personal User', 1, 0)";
if ( !($result = $db->sql_query($sql)) )
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2010-05-18 18:50 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2010-05-18 18:50 UTC (permalink / raw
To: gentoo-commits
tomk 10/05/18 18:50:36
Modified: usercp_register.php
Log:
Allow profile spammer identification based solely on timezone and language selection
Revision Changes Path
1.31 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.31&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.31&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.30&r2=1.31
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- usercp_register.php 19 Aug 2009 18:00:44 -0000 1.30
+++ usercp_register.php 18 May 2010 18:50:36 -0000 1.31
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.30 2009/08/19 18:00:44 robbat2 Exp $
+ * $Id: usercp_register.php,v 1.31 2010/05/18 18:50:36 tomk Exp $
*
*
***************************************************************************/
@@ -646,7 +646,7 @@
// TODO: this should probably also check for the fist style in the list too
- if ( ! empty($website) && $user_lang == get_first_language_option() && $user_timezone == get_first_tz_option() )
+ if ( $user_lang == get_first_language_option() && $user_timezone == get_first_tz_option() )
{
// This is probably a registration bot
$is_spammer = TRUE;
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2010-05-19 10:03 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2010-05-19 10:03 UTC (permalink / raw
To: gentoo-commits
tomk 10/05/19 10:03:57
Modified: usercp_register.php
Log:
Only allow spaces in usernames and not all whitespace characters
Revision Changes Path
1.32 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.32&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.32&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.31&r2=1.32
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- usercp_register.php 18 May 2010 18:50:36 -0000 1.31
+++ usercp_register.php 19 May 2010 10:03:57 -0000 1.32
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.31 2010/05/18 18:50:36 tomk Exp $
+ * $Id: usercp_register.php,v 1.32 2010/05/19 10:03:57 tomk Exp $
*
*
***************************************************************************/
@@ -505,7 +505,7 @@
}
// Check username (ian!) >
- if ( preg_match('/[^a-z0-9._-\s!]/i', $username) && $mode != 'editprofile')
+ if ( preg_match('/[^a-z0-9._- !]/i', $username) && $mode != 'editprofile')
{
$error = true;
$error_msg = $lang['Username_invalid'];
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2010-05-19 10:22 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2010-05-19 10:22 UTC (permalink / raw
To: gentoo-commits
tomk 10/05/19 10:22:16
Modified: usercp_register.php
Log:
prevent 'range out of order' error in username regex
Revision Changes Path
1.33 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.33&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.33&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.32&r2=1.33
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- usercp_register.php 19 May 2010 10:03:57 -0000 1.32
+++ usercp_register.php 19 May 2010 10:22:15 -0000 1.33
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.32 2010/05/19 10:03:57 tomk Exp $
+ * $Id: usercp_register.php,v 1.33 2010/05/19 10:22:15 tomk Exp $
*
*
***************************************************************************/
@@ -505,7 +505,7 @@
}
// Check username (ian!) >
- if ( preg_match('/[^a-z0-9._- !]/i', $username) && $mode != 'editprofile')
+ if ( preg_match('/[^a-z0-9._\- !]/i', $username) && $mode != 'editprofile')
{
$error = true;
$error_msg = $lang['Username_invalid'];
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2010-09-07 8:23 Dean Stephens (desultory)
0 siblings, 0 replies; 10+ messages in thread
From: Dean Stephens (desultory) @ 2010-09-07 8:23 UTC (permalink / raw
To: gentoo-commits
desultory 10/09/07 08:23:33
Modified: usercp_register.php
Log:
Tweak the profile spammers insertion to avoid breaking replication when dealing with overeager bots.
Revision Changes Path
1.34 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.34&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.34&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.33&r2=1.34
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- usercp_register.php 19 May 2010 10:22:15 -0000 1.33
+++ usercp_register.php 7 Sep 2010 08:23:32 -0000 1.34
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.33 2010/05/19 10:22:15 tomk Exp $
+ * $Id: usercp_register.php,v 1.34 2010/09/07 08:23:32 desultory Exp $
*
*
***************************************************************************/
@@ -671,7 +671,7 @@
// This user is most likely a profile spammer, so insert their info into the spammer database
// then show an error message telling them to contact us in case it's a false positive
- $sql = "INSERT INTO " . SPAMMERS_TABLE . " (username, user_regdate, user_password, user_email, user_icq, user_website, user_occ, user_from, user_interests, user_sig, user_sig_bbcode_uid, user_avatar, user_avatar_type, user_viewemail, user_aim, user_yim, user_msnm, user_jabber, user_attachsig, user_allowsmile, user_allowhtml, user_allowbbcode, user_allow_viewonline, user_notify, user_notify_pm, user_popup_pm, user_timezone, user_dateformat, user_lang, user_style, user_level, user_allow_pm, user_active, user_actkey, user_showavatars, user_reg_ip, user_require_activation, user_author_view)
+ $sql = "INSERT IGNORE INTO " . SPAMMERS_TABLE . " (username, user_regdate, user_password, user_email, user_icq, user_website, user_occ, user_from, user_interests, user_sig, user_sig_bbcode_uid, user_avatar, user_avatar_type, user_viewemail, user_aim, user_yim, user_msnm, user_jabber, user_attachsig, user_allowsmile, user_allowhtml, user_allowbbcode, user_allow_viewonline, user_notify, user_notify_pm, user_popup_pm, user_timezone, user_dateformat, user_lang, user_style, user_level, user_allow_pm, user_active, user_actkey, user_showavatars, user_reg_ip, user_require_activation, user_author_view)
VALUES ('" . str_replace("\'", "''", $username) . "', " . time() . ", '" . str_replace("\'", "''", $new_password) . "', '" . str_replace("\'", "''", $email) . "', '" . str_replace("\'", "''", $icq) . "', '" . str_replace("\'", "''", $website) . "', '" . str_replace("\'", "''", $occupation) . "', '" . str_replace("\'", "''", $location) . "', '" . str_replace("\'", "''", $interests) . "', '" . str_replace("\'", "''", $signature) . "', '$signature_bbcode_uid', $avatar_sql, $viewemail, '" . str_replace("\'", "''", str_replace(' ', '+', $aim)) . "', '" . str_replace("\'", "''", $yim) . "', '" . str_replace("\'", "''", $msn) . "', '" . str_replace("\'", "''", $jabber) . "', $attachsig, $allowsmilies, $allowhtml, $allowbbcode, $allowviewonline, $notifyreply, $notifypm, $popup_pm, $user_timezone, '" . str_replace("\'", "''", $user_dateformat) . "', '" . str_replace("\'", "''", $user_lang) . "', $user_style, 0, 1, ";
if ( $board_config['require_activation'] == USER_ACTIVATION_SELF || $board_config['require_activation'] == USER_ACTIVATION_ADMIN || $coppa || $board_config['require_activation'] == USER_ACTIVATION_WATCHED_IP || $board_config['require_activation'] == USER_ACTIVATION_MULTI_IP )
{
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2011-02-20 11:53 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2011-02-20 11:53 UTC (permalink / raw
To: gentoo-commits
tomk 11/02/20 11:53:55
Modified: usercp_register.php
Log:
typo: /intavl/intval/
Revision Changes Path
1.37 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.37&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.37&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.36&r2=1.37
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- usercp_register.php 20 Feb 2011 11:43:57 -0000 1.36
+++ usercp_register.php 20 Feb 2011 11:53:55 -0000 1.37
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.36 2011/02/20 11:43:57 tomk Exp $
+ * $Id: usercp_register.php,v 1.37 2011/02/20 11:53:55 tomk Exp $
*
*
***************************************************************************/
@@ -740,7 +740,7 @@
$spammer_summary[] = $row['total'] . " - " . $ip;
$search_ip_urls[] = $admin_url . "admin/admin_spammers.$phpEx?mode=search®_ip=" . $ip;
$ban_ip_urls[] = $admin_url . "admin/admin_user_ban.$phpEx?reg_ip=" . $ip;
- $total_spammers += intavl($row['total']);
+ $total_spammers += intval($row['total']);
}
if ($total_spammers > 0)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2011-02-20 12:58 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2011-02-20 12:58 UTC (permalink / raw
To: gentoo-commits
tomk 11/02/20 12:58:50
Modified: usercp_register.php
Log:
don't search stopforumspam.com if we've already idntified the user as a spammer
Revision Changes Path
1.38 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.38&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.38&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.37&r2=1.38
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- usercp_register.php 20 Feb 2011 11:53:55 -0000 1.37
+++ usercp_register.php 20 Feb 2011 12:58:50 -0000 1.38
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.37 2011/02/20 11:53:55 tomk Exp $
+ * $Id: usercp_register.php,v 1.38 2011/02/20 12:58:50 tomk Exp $
*
*
***************************************************************************/
@@ -659,11 +659,13 @@
// 2011-01-31 tomk - stopforumspam.com functionality
include_once($phpbb_root_path . 'includes/stopforumspam.'.$phpEx);
- $stopforumspam_check = stopforumspam_is_spammer($username, $email, decode_ip($user_ip));
+ if (! $is_spammer) {
+ $stopforumspam_check = stopforumspam_is_spammer($username, $email, decode_ip($user_ip));
- if (isset($stopforumspam_check) && count($stopforumspam_check) == 2) {
- $is_spammer = $stopforumspam_check[0];
- $spammer_reason = $stopforumspam_check[1];
+ if (isset($stopforumspam_check) && count($stopforumspam_check) == 2) {
+ $is_spammer = $stopforumspam_check[0];
+ $spammer_reason = $stopforumspam_check[1];
+ }
}
if ($is_spammer)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2012-09-05 2:53 Dean Stephens (desultory)
0 siblings, 0 replies; 10+ messages in thread
From: Dean Stephens (desultory) @ 2012-09-05 2:53 UTC (permalink / raw
To: gentoo-commits
desultory 12/09/05 02:53:22
Modified: usercp_register.php
Log:
Stop reporting automatically caught profile spammers to SFS
Revision Changes Path
1.41 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.41&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.41&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.40&r2=1.41
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- usercp_register.php 17 Jul 2011 14:36:00 -0000 1.40
+++ usercp_register.php 5 Sep 2012 02:53:21 -0000 1.41
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.40 2011/07/17 14:36:00 tomk Exp $
+ * $Id: usercp_register.php,v 1.41 2012/09/05 02:53:21 desultory Exp $
*
*
***************************************************************************/
@@ -709,7 +709,8 @@
}
// post to stopforumspam API
- stopforumspam_add_spammer($username, $email, decode_ip($user_ip), $website, $signature);
+ // or not, false positives from their end were being fed back to them, causing problems for us and them. -- desultory
+ //stopforumspam_add_spammer($username, $email, decode_ip($user_ip), $website, $signature);
$message = $lang['registration_problem'];
^ permalink raw reply [flat|nested] 10+ messages in thread
* [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php
@ 2013-02-25 10:39 Tom Knight (tomk)
0 siblings, 0 replies; 10+ messages in thread
From: Tom Knight (tomk) @ 2013-02-25 10:39 UTC (permalink / raw
To: gentoo-commits
tomk 13/02/25 10:39:07
Modified: usercp_register.php
Log:
ensure code is compatible with php 5.4
Revision Changes Path
1.43 forums/htdocs/includes/usercp_register.php
file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.43&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?rev=1.43&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/includes/usercp_register.php?r1=1.42&r2=1.43
Index: usercp_register.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/includes/usercp_register.php,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- usercp_register.php 12 Jan 2013 13:48:20 -0000 1.42
+++ usercp_register.php 25 Feb 2013 10:39:07 -0000 1.43
@@ -6,7 +6,7 @@
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
- * $Id: usercp_register.php,v 1.42 2013/01/12 13:48:20 tomk Exp $
+ * $Id: usercp_register.php,v 1.43 2013/02/25 10:39:07 tomk Exp $
*
*
***************************************************************************/
@@ -1244,7 +1244,9 @@
// 2005-06-28 tomk - jabber diff++
// 2005-09-07 ian! - adding user_showavatars
- display_avatar_gallery($mode, $avatar_category, $user_id, $email, $current_email, $coppa, $username, $email, &$new_password, &$cur_password, $password_confirm, $icq, $aim, $msn, $yim, $jabber, $website, $location, $occupation, $interests, $signature, $viewemail, $notifypm, $popup_pm, $notifyreply, $attachsig, $allowhtml, $allowbbcode, $allowsmilies, $allowviewonline, $user_style, $user_lang, $user_timezone, $user_dateformat, $userdata['session_id'],$user_showavatars);
+ // 2013-02-25 tomk - call-time pass by reference has been removed in php 5.4
+ //display_avatar_gallery($mode, $avatar_category, $user_id, $email, $current_email, $coppa, $username, $email, &$new_password, &$cur_password, $password_confirm, $icq, $aim, $msn, $yim, $jabber, $website, $location, $occupation, $interests, $signature, $viewemail, $notifypm, $popup_pm, $notifyreply, $attachsig, $allowhtml, $allowbbcode, $allowsmilies, $allowviewonline, $user_style, $user_lang, $user_timezone, $user_dateformat, $userdata['session_id'],$user_showavatars);
+ display_avatar_gallery($mode, $avatar_category, $user_id, $email, $current_email, $coppa, $username, $email, $new_password, $cur_password, $password_confirm, $icq, $aim, $msn, $yim, $jabber, $website, $location, $occupation, $interests, $signature, $viewemail, $notifypm, $popup_pm, $notifyreply, $attachsig, $allowhtml, $allowbbcode, $allowsmilies, $allowviewonline, $user_style, $user_lang, $user_timezone, $user_dateformat, $userdata['session_id'],$user_showavatars);
}
else
{
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-02-25 10:39 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19 10:22 [gentoo-commits] gentoo-projects commit in forums/htdocs/includes: usercp_register.php Tom Knight (tomk)
-- strict thread matches above, loose matches on Subject: below --
2013-02-25 10:39 Tom Knight (tomk)
2012-09-05 2:53 Dean Stephens (desultory)
2011-02-20 12:58 Tom Knight (tomk)
2011-02-20 11:53 Tom Knight (tomk)
2010-09-07 8:23 Dean Stephens (desultory)
2010-05-19 10:03 Tom Knight (tomk)
2010-05-18 18:50 Tom Knight (tomk)
2009-08-19 18:00 Robin H. Johnson (robbat2)
2009-08-18 6:26 Robin H. Johnson (robbat2)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox