public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] gentoo-x86 commit in net-im/pidgin/files: pidgin-2.7.0-icq-fix.patch
@ 2010-05-17  0:59 Olivier Crete (tester)
  0 siblings, 0 replies; only message in thread
From: Olivier Crete (tester) @ 2010-05-17  0:59 UTC (permalink / raw
  To: gentoo-commits

tester      10/05/17 00:59:23

  Added:                pidgin-2.7.0-icq-fix.patch
  Log:
  Remove nls use flag ag (bug #319557) and added upstream patch for ICQ regression (bug #320061)
  (Portage version: 2.1.8.3/cvs/Linux x86_64)

Revision  Changes    Path
1.1                  net-im/pidgin/files/pidgin-2.7.0-icq-fix.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-im/pidgin/files/pidgin-2.7.0-icq-fix.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-im/pidgin/files/pidgin-2.7.0-icq-fix.patch?rev=1.1&content-type=text/plain

Index: pidgin-2.7.0-icq-fix.patch
===================================================================
#
#
# patch "libpurple/protocols/oscar/oscar.c"
#  from [ec79d8d9fcba376be091b363977e8f23c748eff2]
#    to [c8cc188e64cc6b466711a5b56454ce70615b0eea]
#
============================================================
--- libpurple/protocols/oscar/oscar.c	ec79d8d9fcba376be091b363977e8f23c748eff2
+++ libpurple/protocols/oscar/oscar.c	c8cc188e64cc6b466711a5b56454ce70615b0eea
@@ -2486,32 +2486,6 @@ static int incomingim_chan1(OscarData *o
 	tmp = g_string_free(message, FALSE);
 
 	/*
-	 * If the message is from an ICQ user and to an ICQ user then escape any HTML,
-	 * because HTML is not sent over ICQ as a means to format a message.
-	 * So any HTML we receive is intended to be displayed.  Also, \r\n must be
-	 * replaced with <br>
-	 *
-	 * Note: There *may* be some clients which send messages as HTML formatted -
-	 *       they need to be special-cased somehow.
-	 *
-	 * Update: Newer ICQ clients have started sending IMs as HTML.  We can
-	 * distinguish HTML IMs from non-HTML IMs by looking at the features.  If
-	 * the features are "0x 01 06" then the message is plain text.  If the
-	 * features are "0x 01" then the message is HTML.
-	 */
-	if (od->icq && oscar_util_valid_name_icq(userinfo->bn)
-			&& (args->featureslen != 1 || args->features[0] != 0x01))
-	{
-		/* being recevied by ICQ from ICQ - escape HTML so it is displayed as sent */
-		gchar *tmp2 = g_markup_escape_text(tmp, -1);
-		g_free(tmp);
-		tmp = tmp2;
-		tmp2 = purple_strreplace(tmp, "\r\n", "<br>");
-		g_free(tmp);
-		tmp = tmp2;
-	}
-
-	/*
 	 * Convert iChat color tags to normal font tags.
 	 */
 	if (purple_markup_find_tag("body", tmp, &start, &end, &attribs))
@@ -4787,7 +4761,8 @@ oscar_send_im(PurpleConnection *gc, cons
 			tmp2 = purple_markup_strip_html(tmp1);
 			is_html = FALSE;
 		} else {
-			tmp2 = g_strdup(tmp1);
+			/* ICQ 6 wants its HTML wrapped in these tags. Oblige it. */
+			tmp2 = g_strdup_printf("<HTML><BODY>%s</BODY></HTML>", tmp1);
 			is_html = TRUE;
 		}
 		g_free(tmp1);






^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-17  0:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-17  0:59 [gentoo-commits] gentoo-x86 commit in net-im/pidgin/files: pidgin-2.7.0-icq-fix.patch Olivier Crete (tester)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox