From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 40520158041 for ; Wed, 11 Jun 2025 03:26:32 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 2D09233BF29 for ; Wed, 11 Jun 2025 03:26:32 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 1D7AE1137ED; Wed, 11 Jun 2025 03:26:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 1356D1103DA for ; Wed, 11 Jun 2025 03:26:31 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id BECEE33BE26 for ; Wed, 11 Jun 2025 03:26:30 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 2A34F82C for ; Wed, 11 Jun 2025 03:26:29 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1749612375.97f687702986db8ffc5e420a361d702d0b6dc2cb.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/ecompress X-VCS-Directories: bin/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 97f687702986db8ffc5e420a361d702d0b6dc2cb X-VCS-Branch: master Date: Wed, 11 Jun 2025 03:26:29 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 4634df8f-1c67-4f28-8867-1493dedcabbe X-Archives-Hash: 05fb286094ba2b7ec76c88ed4698e6d7 commit: 97f687702986db8ffc5e420a361d702d0b6dc2cb Author: Kerin Millar plushkava net> AuthorDate: Mon Jun 9 08:35:18 2025 +0000 Commit: Sam James gentoo org> CommitDate: Wed Jun 11 03:26:15 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=97f68770 ecompress: sort colliding pathnames in QA warning Where the do_queue() function determines that there are any colliding pathnames, lexicographically sort them at the point of conveying them with eqawarn(). Further, employ the ${param@Q} form of expansion so as to ensure that all pathnames are legible, and that control characters and (some) whitespace characters are not printed in their raw form. Doing so is acceptable, given a target of >=bash-4.4. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/ecompress | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/ecompress b/bin/ecompress index 345b625ab8..1169255674 100755 --- a/bin/ecompress +++ b/bin/ecompress @@ -108,9 +108,9 @@ do_queue() { if (( ${#collision_by[@]} )); then eqawarn "QA Notice: Colliding files found by ecompress:" eqawarn - for path in "${!collision_by[@]}"; do - eqawarn " ${path}" - done + while IFS= read -r path; do + eqawarn " ${path@Q}" + done < <(printf '%s\n' "${!collision_by[@]}" | sort) eqawarn eqawarn "Please remove the extraneous compressed variants." fi