From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9845215807A for ; Sat, 07 Jun 2025 22:54:53 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 83E68343126 for ; Sat, 07 Jun 2025 22:54:53 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 0CC661103DD; Sat, 07 Jun 2025 22:54:47 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 012491103DD for ; Sat, 07 Jun 2025 22:54:46 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 948753430C1 for ; Sat, 07 Jun 2025 22:54:46 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id BF1CA265C for ; Sat, 07 Jun 2025 22:54:44 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1749336846.2700a297abd2b565ad7d017792f87d92f70a44e2.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/bashrc-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 2700a297abd2b565ad7d017792f87d92f70a44e2 X-VCS-Branch: master Date: Sat, 07 Jun 2025 22:54:44 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 6ec2580b-fdd9-49cc-81b5-eae5f7e22826 X-Archives-Hash: 7a64be31e895bcd2d16c51ef98cd542f commit: 2700a297abd2b565ad7d017792f87d92f70a44e2 Author: Kerin Millar plushkava net> AuthorDate: Sat Jun 7 15:41:01 2025 +0000 Commit: Sam James gentoo org> CommitDate: Sat Jun 7 22:54:06 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=2700a297 bashrc-functions.sh: use continue in register_{die,success}_hook() Where the register_die_hook() and register_success_hook() functions encounter an invalid parameter, have them skip over the parameter with the continue builtin, as opposed to the true (:) builtin. That way, the code better expresses its intent. See-also: bf17d5963cead8c930d3e996f976e57b99d839f8 Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/bashrc-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/bashrc-functions.sh b/bin/bashrc-functions.sh index 568f16da6c..32611ebaa8 100644 --- a/bin/bashrc-functions.sh +++ b/bin/bashrc-functions.sh @@ -7,7 +7,7 @@ register_die_hook() { for hook; do if [[ ${hook} != +([![:space:]]) ]]; then - : + continue elif ! contains_word "${hook}" "${EBUILD_DEATH_HOOKS}"; then export EBUILD_DEATH_HOOKS+=" ${hook}" fi @@ -19,7 +19,7 @@ register_success_hook() { for hook; do if [[ ${hook} != +([![:space:]]) ]]; then - : + continue elif ! contains_word "${hook}" "${EBUILD_SUCCESS_HOOKS}"; then export EBUILD_SUCCESS_HOOKS+=" ${hook}" fi