From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8F8D51580EB for ; Fri, 30 May 2025 07:37:54 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 7DDE6343111 for ; Fri, 30 May 2025 07:37:54 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 1D6511104B0; Fri, 30 May 2025 07:37:41 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 12C9B1104A8 for ; Fri, 30 May 2025 07:37:41 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B67873430A6 for ; Fri, 30 May 2025 07:37:40 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7737528F2 for ; Fri, 30 May 2025 07:37:38 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1748590652.80ce8be0701650cae21c91cfe2925a5e1a208c2a.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: bin/install-qa-check.d/90gcc-warnings X-VCS-Directories: bin/install-qa-check.d/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 80ce8be0701650cae21c91cfe2925a5e1a208c2a X-VCS-Branch: master Date: Fri, 30 May 2025 07:37:38 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 3298d191-9cea-44d2-af33-0562e20ac0e8 X-Archives-Hash: 059ab6f231d747080b35adb16cf1d193 commit: 80ce8be0701650cae21c91cfe2925a5e1a208c2a Author: Kerin Millar plushkava net> AuthorDate: Thu May 22 21:19:09 2025 +0000 Commit: Sam James gentoo org> CommitDate: Fri May 30 07:37:32 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=80ce8be0 90gcc-warnings: improve an ill-informed comment Explain why LC_CTYPE and LC_COLLATE are adjusted in a slightly more informative way. Further, clarify why GNU grep -a is beneficial, for it has nothing to do with UTF-8 but, rather, the presence of NUL bytes. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/install-qa-check.d/90gcc-warnings | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings index 0662a94637..bf749f74b6 100644 --- a/bin/install-qa-check.d/90gcc-warnings +++ b/bin/install-qa-check.d/90gcc-warnings @@ -147,10 +147,12 @@ gcc_warn_check() { #': warning: not enough variable arguments to fit a sentinel' ) - # Force C locale to work around slow multibyte locales, bug #160234 - # Force text mode as newer grep will treat non-ASCII (e.g. UTF-8) as - # binary when we run in the C locale. f=$( + # Coerce C as the character type for performance reasons, per + # bug #160234. Coerce C as the collation to guarantee that + # ranges are handled appropriately. Also, pass -a to GNU grep + # to prevent binary data - that is, anything containing a NUL + # byte - from suppressing the printing of matching lines. export LC_ALL= LC_COLLATE=C LC_CTYPE=C IFS='|' if [[ ${PORTAGE_LOG_FILE} == *.gz ]]; then