From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 817671584AD for ; Fri, 09 May 2025 07:12:33 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 6B864343105 for ; Fri, 09 May 2025 07:12:33 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 51B9B1103DD; Fri, 09 May 2025 07:12:25 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 46E161103DD for ; Fri, 09 May 2025 07:12:25 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E49C93430DB for ; Fri, 09 May 2025 07:12:24 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 507F92822 for ; Fri, 09 May 2025 07:12:23 +0000 (UTC) From: "Eli Schwartz" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Eli Schwartz" Message-ID: <1746774590.88a2f23c6c3b2bce6f45bbbc899380cfb456394d.eschwartz@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/newt/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-libs/newt/newt-0.52.25.ebuild X-VCS-Directories: dev-libs/newt/ X-VCS-Committer: eschwartz X-VCS-Committer-Name: Eli Schwartz X-VCS-Revision: 88a2f23c6c3b2bce6f45bbbc899380cfb456394d X-VCS-Branch: master Date: Fri, 09 May 2025 07:12:23 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 02124e55-4283-45c4-82ef-a9a3847312a1 X-Archives-Hash: 9c82d2c34030ca803e95a1e82e51017b commit: 88a2f23c6c3b2bce6f45bbbc899380cfb456394d Author: Eli Schwartz gentoo org> AuthorDate: Tue May 6 08:14:59 2025 +0000 Commit: Eli Schwartz gentoo org> CommitDate: Fri May 9 07:09:50 2025 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88a2f23c dev-libs/newt: vastly simplify configure/build without copying sources configuring building and installing multiple times is very complicated and also tends to slow down due to repeated configures. Upstream since 2002 (!!!) has supported configuring and building for multiple python versions in a single `./configure && make` It is unclear why the copy+configure route was ever taken. Acked-by: Ben Kohler gentoo.org> Signed-off-by: Eli Schwartz gentoo.org> dev-libs/newt/newt-0.52.25.ebuild | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/dev-libs/newt/newt-0.52.25.ebuild b/dev-libs/newt/newt-0.52.25.ebuild index a6855be8aa13..74ea42133082 100644 --- a/dev-libs/newt/newt-0.52.25.ebuild +++ b/dev-libs/newt/newt-0.52.25.ebuild @@ -59,34 +59,28 @@ src_prepare() { default eautoreconf - - # can't build out-of-source - python_copy_sources } src_configure() { - configuring() { - econf \ - --with-python="${EPYTHON}" \ - $(use_with gpm gpm-support) \ - $(use_with tcl) \ - $(use_enable nls) + local versions= + getversions() { + versions+="${EPYTHON} " } - python_foreach_impl run_in_build_dir configuring -} + python_foreach_impl getversions -src_compile() { - python_foreach_impl run_in_build_dir emake + econf \ + --with-python="${versions}" \ + $(use_with gpm gpm-support) \ + $(use_with tcl) \ + $(use_enable nls) } src_install() { - installit() { - emake \ - DESTDIR="${D}" \ - install - python_optimize - } - python_foreach_impl run_in_build_dir installit + emake \ + DESTDIR="${D}" \ + install + python_foreach_impl python_optimize + dodoc peanuts.py popcorn.py tutorial.sgml doman whiptail.1 einstalldocs