[gentoo-commits] proj/chromium-tools:master commit in: /

["Matt Jolly" <kangie@gentoo.org>]

commit:     4aedd6f8789600d542d7498a7ebbff49353b3de4
Author:     Matt Jolly <kangie <AT> gentoo <DOT> org>
AuthorDate: Mon Mar 10 13:42:13 2025 +0000
Commit:     Matt Jolly <kangie <AT> gentoo <DOT> org>
CommitDate: Mon Mar 10 13:42:13 2025 +0000
URL:        https://gitweb.gentoo.org/proj/chromium-tools.git/commit/?id=4aedd6f8

Be more specific about where a fetch failed

We really shouldn't see one fail and the other succeed, but if it does
happen it's really nice to know where to start looking.

Signed-off-by: Matt Jolly <kangie <AT> gentoo.org>

 get-chromium-toolchain-strings.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/get-chromium-toolchain-strings.py b/get-chromium-toolchain-strings.py
index d7c124d..ee8ca21 100755
--- a/get-chromium-toolchain-strings.py
+++ b/get-chromium-toolchain-strings.py
@@ -20,8 +20,8 @@ def get_testfonts(url) -> str:
         str: The SHA256 of the testfonts, or None if not found.
         """
 
-    # We're not properly parsing the DEPS file, but it's 'close enough' to JSON that
-    # we can throw away the preamble and do some remediation to read the values in.
+    # We're not properly parsing the DEPS file (it's basically python), but it's 'close enough'
+    # to JSON that we can throw away the preamble and do some remediation to read the values in.
 
     testfonts = None
     response = requests.get(url)
@@ -145,7 +145,7 @@ def get_testfonts(url) -> str:
         # Now we can get the testfonts SHA
         return deps['src/third_party/test_fonts/test_fonts']['objects'][0]['object_name']
     else:
-        raise ValueError(f"Failed to get revision info. Status code: {response.status_code}")
+        raise ValueError(f"Failed to get testfont revision info. Status code: {response.status_code}")
 
     return testfonts
 
@@ -181,7 +181,7 @@ def get_revision_info(url) -> str:
             raise ValueError("Failed to extract revision and sub-revision")
         return revision, sub_revision
     else:
-        raise ValueError(f"Failed to get revision info. Status code: {response.status_code}")
+        raise ValueError(f"Failed to get Clang and Rust revision info. Status code: {response.status_code}")
 
 
 def main():
@@ -194,6 +194,7 @@ def main():
     clang_revision, clang_sub_revision = get_revision_info(clang_url)
     rust_revision, rust_sub_revision = get_revision_info(rust_url)
     testfonts = get_testfonts(deps_url)
+    print(f"Chromium toolchain strings for: {version}")
     if clang_revision and clang_sub_revision:
         print(f"clang revision: {clang_revision}-{clang_sub_revision}")
     else: