From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F06C01582EF for ; Wed, 05 Mar 2025 06:40:30 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id D0784342FEB for ; Wed, 05 Mar 2025 06:40:30 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 0A0751102F2; Wed, 05 Mar 2025 06:40:26 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id F3C0B1102F2 for ; Wed, 05 Mar 2025 06:40:25 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AF7C1342F99 for ; Wed, 05 Mar 2025 06:40:25 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 175BA287B for ; Wed, 05 Mar 2025 06:40:24 +0000 (UTC) From: "Arthur Zamarin" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Arthur Zamarin" Message-ID: <1741156803.611a1c75c42457c619bc526620eda77aae00d41d.arthurzam@gentoo> Subject: [gentoo-commits] proj/pkgcore/pkgdev:main commit in: src/pkgdev/scripts/ X-VCS-Repository: proj/pkgcore/pkgdev X-VCS-Files: src/pkgdev/scripts/pkgdev_tatt.py X-VCS-Directories: src/pkgdev/scripts/ X-VCS-Committer: arthurzam X-VCS-Committer-Name: Arthur Zamarin X-VCS-Revision: 611a1c75c42457c619bc526620eda77aae00d41d X-VCS-Branch: main Date: Wed, 05 Mar 2025 06:40:24 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 621ca258-4c5d-49c3-a66e-917110b6a8ff X-Archives-Hash: 19e7bb0b71bc89f22c5cff67c731c518 commit: 611a1c75c42457c619bc526620eda77aae00d41d Author: Arthur Zamarin gentoo org> AuthorDate: Wed Mar 5 06:36:37 2025 +0000 Commit: Arthur Zamarin gentoo org> CommitDate: Wed Mar 5 06:40:03 2025 +0000 URL: https://gitweb.gentoo.org/proj/pkgcore/pkgdev.git/commit/?id=611a1c75 tatt: explain why no jobs are being created (-u 0 -t) This can happen if "-u 0 -t" is passed to tatt, but the package defines no src_test phase. In this case, the tatt script will generate no jobs and the user is bewildered as to why. Signed-off-by: Arthur Zamarin gentoo.org> src/pkgdev/scripts/pkgdev_tatt.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pkgdev/scripts/pkgdev_tatt.py b/src/pkgdev/scripts/pkgdev_tatt.py index 65e3392..75e50cf 100644 --- a/src/pkgdev/scripts/pkgdev_tatt.py +++ b/src/pkgdev/scripts/pkgdev_tatt.py @@ -384,6 +384,12 @@ def main(options, out, err): from jinja2 import Template + if not any("test" in pkg.defined_phases for pkg in pkgs): + if not options.use_combos > 0: + return err.error( + "no packages define a src_test, and --use-combos is not a positive integer. Cannot create any jobs, exiting..." + ) + script = Template(template, trim_blocks=True, lstrip_blocks=True).render( jobs=list(_build_jobs(options, pkgs)), report_file=job_name + ".report",