From: "Arthur Zamarin" <arthurzam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-metrics/prometheus-podman-exporter/files/, ...
Date: Fri, 28 Feb 2025 17:56:22 +0000 (UTC) [thread overview]
Message-ID: <1740765375.2efffa45883dedec6e886898a2f54d27ad3876e8.arthurzam@gentoo> (raw)
commit: 2efffa45883dedec6e886898a2f54d27ad3876e8
Author: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
AuthorDate: Fri Feb 28 17:38:30 2025 +0000
Commit: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
CommitDate: Fri Feb 28 17:56:15 2025 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2efffa45
app-metrics/prometheus-podman-exporter: move patch from inline to files/ [QA]
This was weird solution, with nothing to gain from inline patch in the
ebuild. No variable substitution, no conditional, nothing. It was even
the same file across versions.
Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org>
...eus-podman-exporter-1.10.1-gentoo-systemd.patch | 22 +++++++++++++++
.../prometheus-podman-exporter-1.10.1.ebuild | 32 ++--------------------
.../prometheus-podman-exporter-1.11.0.ebuild | 32 ++--------------------
.../prometheus-podman-exporter-1.12.0.ebuild | 32 ++--------------------
.../prometheus-podman-exporter-9999.ebuild | 32 ++--------------------
5 files changed, 30 insertions(+), 120 deletions(-)
diff --git a/app-metrics/prometheus-podman-exporter/files/prometheus-podman-exporter-1.10.1-gentoo-systemd.patch b/app-metrics/prometheus-podman-exporter/files/prometheus-podman-exporter-1.10.1-gentoo-systemd.patch
new file mode 100644
index 000000000000..b4006da393a4
--- /dev/null
+++ b/app-metrics/prometheus-podman-exporter/files/prometheus-podman-exporter-1.10.1-gentoo-systemd.patch
@@ -0,0 +1,22 @@
+--- a/contrib/systemd/system/prometheus-podman-exporter.service
++++ b/contrib/systemd/system/prometheus-podman-exporter.service
+@@ -2,7 +2,7 @@
+ Description=Prometheus exporter for podman (v4) machine
+ [Service]
+ Restart=on-failure
+-EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
++EnvironmentFile=-/etc/default/prometheus-podman-exporter
+ ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
+ ExecReload=/bin/kill -HUP $MAINPID
+ TimeoutStopSec=20s
+--- a/contrib/systemd/user/prometheus-podman-exporter.service
++++ b/contrib/systemd/user/prometheus-podman-exporter.service
+@@ -2,7 +2,7 @@
+ Description=Prometheus exporter for podman (v4) machine
+ [Service]
+ Restart=on-failure
+-EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
++EnvironmentFile=-/etc/default/prometheus-podman-exporter
+ EnvironmentFile=-%h/.config/prometheus-podman-exporter
+ ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
+ ExecReload=/bin/kill -HUP $MAINPID
diff --git a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.10.1.ebuild b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.10.1.ebuild
index 4452311819fe..990b86c7e0df 100644
--- a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.10.1.ebuild
+++ b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.10.1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -28,37 +28,9 @@ IUSE="btrfs systemd"
RESTRICT="test"
PATCHES=(
- "${T}/gentoo-specific-systemd-service.patch"
+ "${FILESDIR}/${PN}-1.10.1-gentoo-systemd.patch"
)
-src_prepare() {
- cat <<-'EOF' > "${T}/gentoo-specific-systemd-service.patch"
- --- a/contrib/systemd/system/prometheus-podman-exporter.service
- +++ b/contrib/systemd/system/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- TimeoutStopSec=20s
- --- a/contrib/systemd/user/prometheus-podman-exporter.service
- +++ b/contrib/systemd/user/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- EnvironmentFile=-%h/.config/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- EOF
- default
-}
-
src_compile() {
export BUILDTAGS="exclude_graphdriver_devicemapper"
use !btrfs && BUILDTAGS+=",exclude_graphdriver_btrfs,btrfs_noversion"
diff --git a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.11.0.ebuild b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.11.0.ebuild
index 4452311819fe..990b86c7e0df 100644
--- a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.11.0.ebuild
+++ b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.11.0.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -28,37 +28,9 @@ IUSE="btrfs systemd"
RESTRICT="test"
PATCHES=(
- "${T}/gentoo-specific-systemd-service.patch"
+ "${FILESDIR}/${PN}-1.10.1-gentoo-systemd.patch"
)
-src_prepare() {
- cat <<-'EOF' > "${T}/gentoo-specific-systemd-service.patch"
- --- a/contrib/systemd/system/prometheus-podman-exporter.service
- +++ b/contrib/systemd/system/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- TimeoutStopSec=20s
- --- a/contrib/systemd/user/prometheus-podman-exporter.service
- +++ b/contrib/systemd/user/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- EnvironmentFile=-%h/.config/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- EOF
- default
-}
-
src_compile() {
export BUILDTAGS="exclude_graphdriver_devicemapper"
use !btrfs && BUILDTAGS+=",exclude_graphdriver_btrfs,btrfs_noversion"
diff --git a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.12.0.ebuild b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.12.0.ebuild
index 4452311819fe..990b86c7e0df 100644
--- a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.12.0.ebuild
+++ b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-1.12.0.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -28,37 +28,9 @@ IUSE="btrfs systemd"
RESTRICT="test"
PATCHES=(
- "${T}/gentoo-specific-systemd-service.patch"
+ "${FILESDIR}/${PN}-1.10.1-gentoo-systemd.patch"
)
-src_prepare() {
- cat <<-'EOF' > "${T}/gentoo-specific-systemd-service.patch"
- --- a/contrib/systemd/system/prometheus-podman-exporter.service
- +++ b/contrib/systemd/system/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- TimeoutStopSec=20s
- --- a/contrib/systemd/user/prometheus-podman-exporter.service
- +++ b/contrib/systemd/user/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- EnvironmentFile=-%h/.config/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- EOF
- default
-}
-
src_compile() {
export BUILDTAGS="exclude_graphdriver_devicemapper"
use !btrfs && BUILDTAGS+=",exclude_graphdriver_btrfs,btrfs_noversion"
diff --git a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-9999.ebuild b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-9999.ebuild
index 4452311819fe..990b86c7e0df 100644
--- a/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-9999.ebuild
+++ b/app-metrics/prometheus-podman-exporter/prometheus-podman-exporter-9999.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -28,37 +28,9 @@ IUSE="btrfs systemd"
RESTRICT="test"
PATCHES=(
- "${T}/gentoo-specific-systemd-service.patch"
+ "${FILESDIR}/${PN}-1.10.1-gentoo-systemd.patch"
)
-src_prepare() {
- cat <<-'EOF' > "${T}/gentoo-specific-systemd-service.patch"
- --- a/contrib/systemd/system/prometheus-podman-exporter.service
- +++ b/contrib/systemd/system/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- TimeoutStopSec=20s
- --- a/contrib/systemd/user/prometheus-podman-exporter.service
- +++ b/contrib/systemd/user/prometheus-podman-exporter.service
- @@ -2,7 +2,7 @@
- Description=Prometheus exporter for podman (v4) machine
- [Service]
- Restart=on-failure
- -EnvironmentFile=-/etc/sysconfig/prometheus-podman-exporter
- +EnvironmentFile=-/etc/default/prometheus-podman-exporter
- EnvironmentFile=-%h/.config/prometheus-podman-exporter
- ExecStart=/usr/bin/prometheus-podman-exporter $PODMAN_EXPORTER_OPTS
- ExecReload=/bin/kill -HUP $MAINPID
- EOF
- default
-}
-
src_compile() {
export BUILDTAGS="exclude_graphdriver_devicemapper"
use !btrfs && BUILDTAGS+=",exclude_graphdriver_btrfs,btrfs_noversion"
reply other threads:[~2025-02-28 17:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740765375.2efffa45883dedec6e886898a2f54d27ad3876e8.arthurzam@gentoo \
--to=arthurzam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox