From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0CBF915813A for ; Tue, 21 Jan 2025 21:15:05 +0000 (UTC) Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id AF2C3335D6A for ; Tue, 21 Jan 2025 21:15:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8BFD9E01E4; Tue, 21 Jan 2025 21:15:02 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1867EE01E4 for ; Tue, 21 Jan 2025 21:15:00 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 230DA340906 for ; Tue, 21 Jan 2025 21:14:59 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id AB0DB97F for ; Tue, 21 Jan 2025 21:14:57 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1737493912.7405367572e2f07cd35a5abd28212c640ac89b10.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/ X-VCS-Repository: proj/portage X-VCS-Files: lib/portage/locks.py X-VCS-Directories: lib/portage/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 7405367572e2f07cd35a5abd28212c640ac89b10 X-VCS-Branch: master Date: Tue, 21 Jan 2025 21:14:57 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c4712313-98ce-496e-8399-9104f4f93c63 X-Archives-Hash: 517228442b93c5e365c524f54710b241 commit: 7405367572e2f07cd35a5abd28212c640ac89b10 Author: Florian Schmaus gentoo org> AuthorDate: Sun Jan 12 11:41:33 2025 +0000 Commit: Sam James gentoo org> CommitDate: Tue Jan 21 21:11:52 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=74053675 locks: Drop comment regarding sleep() call The call was added with 78b1ba8 in 2004 and later commented out with 989d520f6ef6 in 2004 (both from portage-cvs.git). It should be safe to say that it did not prove necessary, so let's remove it. Signed-off-by: Florian Schmaus gentoo.org> Closes: https://github.com/gentoo/portage/pull/1418 Signed-off-by: Sam James gentoo.org> lib/portage/locks.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/portage/locks.py b/lib/portage/locks.py index ee40451b12..c3eff5c56d 100644 --- a/lib/portage/locks.py +++ b/lib/portage/locks.py @@ -549,12 +549,6 @@ def unlockfile(mytuple): raise OSError(_("Failed to unlock file '%s'\n") % lockfilename) try: - # This sleep call was added to allow other processes that are - # waiting for a lock to be able to grab it before it is deleted. - # lockfile() already accounts for this situation, however, and - # the sleep here adds more time than is saved overall, so am - # commenting until it is proved necessary. - # time.sleep(0.0001) if unlinkfile: locking_method(myfd, fcntl.LOCK_EX | fcntl.LOCK_NB) # We won the lock, so there isn't competition for it.