public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/yoshimi/, media-sound/yoshimi/files/
Date: Thu, 26 Dec 2024 17:50:17 +0000 (UTC)	[thread overview]
Message-ID: <1735235312.77526e7efa64cb62f7246fc05ab948878118ad5d.ionen@gentoo> (raw)

commit:     77526e7efa64cb62f7246fc05ab948878118ad5d
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Thu Dec 26 07:40:40 2024 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Thu Dec 26 17:48:32 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77526e7e

media-sound/yoshimi: add binding := to fltk & fix build with 1.4

1.4.x seems to have dropped some transitive includes, and this needs
to include what it uses.

:= due to new soname

Have not tried wayland (new in fltk-1.4), but given the build fix
revealed that it uses some X-specific bits, odds are it'll be
broken without fltk[X(+)] and so added that as well.

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 media-sound/yoshimi/files/yoshimi-2.3.3.1-fltk1.4.patch   | 15 +++++++++++++++
 .../{yoshimi-2.3.3.1.ebuild => yoshimi-2.3.3.1-r1.ebuild} |  6 +++++-
 .../{yoshimi-2.3.3.2.ebuild => yoshimi-2.3.3.2-r1.ebuild} |  6 +++++-
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/media-sound/yoshimi/files/yoshimi-2.3.3.1-fltk1.4.patch b/media-sound/yoshimi/files/yoshimi-2.3.3.1-fltk1.4.patch
new file mode 100644
index 000000000000..e3266ce7af7a
--- /dev/null
+++ b/media-sound/yoshimi/files/yoshimi-2.3.3.1-fltk1.4.patch
@@ -0,0 +1,15 @@
+MiscGui.cpp:1434:18: error: 'fl_display' was not declared ...
+
+Other files are using x.H, but that header is deprecated and
+the correct one is platform.H. fl_display is X-specific, so
+this likely cannot work without fltk[X] at the moment.
+--- a/UI/MiscGui.cpp
++++ b/UI/MiscGui.cpp
+@@ -28,6 +28,7 @@
+ 
+ #include <FL/Fl.H>
+ #include <FL/fl_draw.H>
++#include <FL/platform.H>
+ 
+ #include <cairo.h>
+ #include <cairo-xlib.h>

diff --git a/media-sound/yoshimi/yoshimi-2.3.3.1.ebuild b/media-sound/yoshimi/yoshimi-2.3.3.1-r1.ebuild
similarity index 91%
rename from media-sound/yoshimi/yoshimi-2.3.3.1.ebuild
rename to media-sound/yoshimi/yoshimi-2.3.3.1-r1.ebuild
index d52b5bb9ab3d..d25e3732e7d9 100644
--- a/media-sound/yoshimi/yoshimi-2.3.3.1.ebuild
+++ b/media-sound/yoshimi/yoshimi-2.3.3.1-r1.ebuild
@@ -27,13 +27,17 @@ DEPEND="
 	sys-libs/zlib
 	virtual/jack
 	x11-libs/cairo[X]
-	x11-libs/fltk:1[opengl]
+	x11-libs/fltk:1=[X(+),opengl]
 	lv2? ( media-libs/lv2 )
 "
 RDEPEND="${DEPEND}"
 
 DOCS=( ../Changelog ../README.txt )
 
+PATCHES=(
+	"${FILESDIR}"/${PN}-2.3.3.1-fltk1.4.patch
+)
+
 src_prepare() {
 	cmake_src_prepare
 	sed -e "/^install.*doc.*DATAROOTDIR/s/${PN}/${PF}/" -i CMakeLists.txt || die

diff --git a/media-sound/yoshimi/yoshimi-2.3.3.2.ebuild b/media-sound/yoshimi/yoshimi-2.3.3.2-r1.ebuild
similarity index 91%
rename from media-sound/yoshimi/yoshimi-2.3.3.2.ebuild
rename to media-sound/yoshimi/yoshimi-2.3.3.2-r1.ebuild
index 42acb9b39317..67ffcae93119 100644
--- a/media-sound/yoshimi/yoshimi-2.3.3.2.ebuild
+++ b/media-sound/yoshimi/yoshimi-2.3.3.2-r1.ebuild
@@ -27,13 +27,17 @@ DEPEND="
 	sys-libs/zlib
 	virtual/jack
 	x11-libs/cairo[X]
-	x11-libs/fltk:1[opengl]
+	x11-libs/fltk:1=[X(+),opengl]
 	lv2? ( media-libs/lv2 )
 "
 RDEPEND="${DEPEND}"
 
 DOCS=( ../Changelog ../README.txt )
 
+PATCHES=(
+	"${FILESDIR}"/${PN}-2.3.3.1-fltk1.4.patch
+)
+
 src_prepare() {
 	cmake_src_prepare
 	sed -e "/^install.*doc.*DATAROOTDIR/s/${PN}/${PF}/" -i CMakeLists.txt || die


             reply	other threads:[~2024-12-26 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 17:50 Ionen Wolkens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-13 15:02 [gentoo-commits] repo/gentoo:master commit in: media-sound/yoshimi/, media-sound/yoshimi/files/ Andreas Sturmlechner
2020-08-12  7:23 Joonas Niilola
2019-05-08 17:05 Andreas Sturmlechner
2019-05-08 17:05 Andreas Sturmlechner
2019-01-04 19:31 Tim Harder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1735235312.77526e7efa64cb62f7246fc05ab948878118ad5d.ionen@gentoo \
    --to=ionen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox