From: "Conrad Kostecki" <conikost@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: www-client/chromium/files/
Date: Fri, 6 Dec 2024 23:12:04 +0000 (UTC) [thread overview]
Message-ID: <1733526691.6bbec43dd536e6b62d69ffeb9ab5eb02e463f34f.conikost@gentoo> (raw)
commit: 6bbec43dd536e6b62d69ffeb9ab5eb02e463f34f
Author: Michael Mair-Keimberger <mmk <AT> levelnine <DOT> at>
AuthorDate: Tue Dec 3 19:31:03 2024 +0000
Commit: Conrad Kostecki <conikost <AT> gentoo <DOT> org>
CommitDate: Fri Dec 6 23:11:31 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6bbec43d
www-client/chromium: remove unused patch
Signed-off-by: Michael Mair-Keimberger <mmk <AT> levelnine.at>
Signed-off-by: Conrad Kostecki <conikost <AT> gentoo.org>
.../files/chromium-127-updater-systemd.patch | 73 ----------------------
1 file changed, 73 deletions(-)
diff --git a/www-client/chromium/files/chromium-127-updater-systemd.patch b/www-client/chromium/files/chromium-127-updater-systemd.patch
deleted file mode 100644
index 57e9029b9378..000000000000
--- a/www-client/chromium/files/chromium-127-updater-systemd.patch
+++ /dev/null
@@ -1,73 +0,0 @@
-https://github.com/chromium/chromium/commit/570332aad61afab5d9d88a8438bae53ea28a298a
-From: Noah Rose Ledesma <noahrose@google.com>
-Date: Wed, 31 Jul 2024 17:59:12 +0000
-Subject: [PATCH] Use libs instead of pkg_config for linux deps
-
-pkg_config can cause builds to fail if the requested packages are not
-present, regardless of if the lib is depended upon by the target being
-built.
-
-This issue can be avoided by setting 'libs' instead. I'm not sure why we
-didn't do so in the first place.
-
-Bug: 355967882
-Change-Id: Ie5dc4c03b08d7c1e26458ea143f6dc812b670544
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5749680
-Reviewed-by: Sorin Jianu <sorin@chromium.org>
-Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
-Cr-Commit-Position: refs/heads/main@{#1335558}
---- a/chrome/updater/BUILD.gn
-+++ b/chrome/updater/BUILD.gn
-@@ -367,9 +367,10 @@ if (is_win || is_mac || is_linux) {
- "update_service_internal_impl_qualifying_linux.cc",
- "update_usage_stats_task_linux.cc",
- ]
-- public_configs = [
-- "linux:libcurl",
-- "linux:libsystemd",
-+
-+ libs = [
-+ "curl",
-+ "systemd",
- ]
- }
- }
-@@ -1040,7 +1041,7 @@ if (is_win || is_mac || is_linux) {
-
- data += [ "//chrome/test/data/updater/updater_qualification_app.crx" ]
- data_deps += [ "//chrome/updater/linux:updater_test" ]
-- public_configs = [ "linux:libsystemd" ]
-+ libs = [ "systemd" ]
- }
-
- if (is_posix) {
---- a/chrome/updater/linux/BUILD.gn
-+++ b/chrome/updater/linux/BUILD.gn
-@@ -2,7 +2,6 @@
- # Use of this source code is governed by a BSD-style license that can be
- # found in the LICENSE file.
-
--import("//build/config/linux/pkg_config.gni")
- import("//chrome/updater/zip.gni")
-
- # This target builds the updater executable and unittests.
-@@ -13,18 +12,10 @@ group("linux") {
- ]
- }
-
--pkg_config("libcurl") {
-- packages = [ "libcurl" ]
--}
--
--pkg_config("libsystemd") {
-- packages = [ "libsystemd" ]
--}
--
- source_set("updater_executable") {
- sources = [ "main.cc" ]
- deps = [ "//chrome/updater:base" ]
-- public_configs = [ ":libsystemd" ]
-+ libs = [ "systemd" ]
- }
-
- executable("updater") {
next reply other threads:[~2024-12-06 23:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 23:12 Conrad Kostecki [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-05 2:53 [gentoo-commits] repo/gentoo:master commit in: www-client/chromium/files/ Matt Jolly
2025-01-20 21:57 Conrad Kostecki
2025-01-04 22:47 Conrad Kostecki
2024-10-15 21:46 Conrad Kostecki
2024-06-27 15:40 Conrad Kostecki
2024-06-22 18:54 Conrad Kostecki
2024-04-18 19:32 Conrad Kostecki
2024-03-27 7:55 Matt Jolly
2024-03-05 9:18 Petr Vaněk
2023-10-04 21:45 Conrad Kostecki
2023-09-13 18:43 Conrad Kostecki
2023-07-02 1:43 Conrad Kostecki
2023-06-30 19:03 Stephan Hartmann
2023-05-07 18:22 Mike Gilbert
2023-05-02 20:05 Mike Gilbert
2023-04-23 14:46 Mike Gilbert
2023-01-01 18:16 Conrad Kostecki
2022-12-22 19:54 Stephan Hartmann
2022-02-03 9:18 Stephan Hartmann
2021-11-20 10:08 Stephan Hartmann
2021-08-28 19:43 Stephan Hartmann
2021-07-03 7:51 Stephan Hartmann
2020-07-14 17:32 Mike Gilbert
2020-02-28 14:39 Mike Gilbert
2020-01-30 16:17 Mike Gilbert
2019-06-28 15:30 Mike Gilbert
2019-06-20 14:49 Mike Gilbert
2018-12-29 18:50 Mike Gilbert
2018-11-05 3:30 Mike Gilbert
2018-09-30 21:28 Mike Gilbert
2018-08-08 16:00 Mike Gilbert
2018-07-23 20:40 Mike Gilbert
2018-06-20 21:46 Mike Gilbert
2018-03-13 21:20 Mike Gilbert
2018-03-02 15:01 Mike Gilbert
2018-02-18 22:40 Mike Gilbert
2017-12-31 17:09 Mike Gilbert
2017-12-12 18:17 Mike Gilbert
2017-12-09 23:27 Mike Gilbert
2017-11-17 19:38 Mike Gilbert
2017-10-31 17:15 Mike Gilbert
2017-10-02 21:26 Mike Gilbert
2017-08-09 14:30 Mike Gilbert
2017-06-11 16:50 Mike Gilbert
2017-02-17 1:25 Mike Gilbert
2016-12-04 22:43 Mike Gilbert
2016-11-08 5:47 Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733526691.6bbec43dd536e6b62d69ffeb9ab5eb02e463f34f.conikost@gentoo \
--to=conikost@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox